Add Default Value for vLLM Env Vars#18
Merged
Jdubrick merged 1 commit intoredhat-ai-dev:mainfrom Dec 1, 2025
Merged
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Contributor
michael-valdron
left a comment
There was a problem hiding this comment.
@Jdubrick Might of missed something but I'm still getting the error with blank variables:
INFO 2025-11-28 22:07:15,672 llama_stack.core.utils.config_resolution:45 config_resolution: Using file path: run.yaml
INFO 2025-11-28 22:07:15,675 llama_stack.cli.stack.run:129 server: Using run configuration: /app-root/run.yaml
Traceback (most recent call last):
File "/app-root/.venv/bin/llama", line 10, in <module>
sys.exit(main())
^^^^^^
File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/cli/llama.py", line 53, in main
parser.run(args)
File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/cli/llama.py", line 47, in run
args.func(args)
File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/cli/stack/run.py", line 137, in _run_stack_run_cmd
config = parse_and_maybe_upgrade_config(config_dict)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/core/configure.py", line 180, in parse_and_maybe_upgrade_config
processed_config_dict = replace_env_vars(config_dict)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/core/stack.py", line 150, in replace_env_vars
raise EnvVarError(e.var_name, e.path) from None
llama_stack.core.stack.EnvVarError: Environment variable 'VLLM_URL' not set or empty at providers.inference[0].config.url. Use ${env.VLLM_URL:=default_value} to provide a default value, ${env.VLLM_URL:+value_if_set} to make the field conditional, or ensure the environment variable is set.
michael-valdron
approved these changes
Dec 1, 2025
Contributor
michael-valdron
left a comment
There was a problem hiding this comment.
@Jdubrick Might of missed something but I'm still getting the error with blank variables:
INFO 2025-11-28 22:07:15,672 llama_stack.core.utils.config_resolution:45 config_resolution: Using file path: run.yaml INFO 2025-11-28 22:07:15,675 llama_stack.cli.stack.run:129 server: Using run configuration: /app-root/run.yaml Traceback (most recent call last): File "/app-root/.venv/bin/llama", line 10, in <module> sys.exit(main()) ^^^^^^ File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/cli/llama.py", line 53, in main parser.run(args) File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/cli/llama.py", line 47, in run args.func(args) File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/cli/stack/run.py", line 137, in _run_stack_run_cmd config = parse_and_maybe_upgrade_config(config_dict) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/core/configure.py", line 180, in parse_and_maybe_upgrade_config processed_config_dict = replace_env_vars(config_dict) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/app-root/.venv/lib64/python3.12/site-packages/llama_stack/core/stack.py", line 150, in replace_env_vars raise EnvVarError(e.var_name, e.path) from None llama_stack.core.stack.EnvVarError: Environment variable 'VLLM_URL' not set or empty at providers.inference[0].config.url. Use ${env.VLLM_URL:=default_value} to provide a default value, ${env.VLLM_URL:+value_if_set} to make the field conditional, or ensure the environment variable is set.
Re-ran this with a new build, confirmed it works. lgtm ✔️
Must of ran it with quay.io/redhat-ai-dev/llama-stack last time 🤦
Jdubrick
added a commit
that referenced
this pull request
Jan 14, 2026
* Conditionally Add All Inference Providers (#12) * add all providers conditionally Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add vertex ai provider Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * [RHDHPAI-1170] Add Question Validation Prompt Template Sync Script (#11) * add python script for syncing contents Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add CI for running validation on PRs Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add make commands for running script Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * run the sync with upstream prompt templates Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * cleanup whitespace Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update rag items to 1.8 (#13) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * bump latest version in readme Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * Update build commands readme.md, add cache info for local run in lightspeed-stack.yaml (#16) Signed-off-by: Lucas <lyoon@redhat.com> * [RHIDP-10054] Add YAML Formatter (#17) * v0.0.0 * add Prettier for formatting and update docs Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * resolve conflict and reformat Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add default for vllm envs (#18) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * Konflux onboarding prep work (#19) * add license Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add license headers Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add build step to add license file into container image Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix image tags and digests Signed-off-by: Michael Valdron <mvaldron@redhat.com> * run second build instruction as root Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add enterprise contract labels for llama stack to image build Signed-off-by: Michael Valdron <mvaldron@redhat.com> * ignore existance errors from creating /license directory during image build Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix user switching order Signed-off-by: Michael Valdron <mvaldron@redhat.com> * include additional instructions about accessing host model server Signed-off-by: Michael Valdron <mvaldron@redhat.com> * feedback: remove extra descriptor for running locally Signed-off-by: Michael Valdron <mvaldron@redhat.com> * feedback: bump project version to match latest release version Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add troubleshooting section (#20) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update prompt template (#22) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * prepare for release-v0.1.2 Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> Signed-off-by: Lucas <lyoon@redhat.com> Signed-off-by: Michael Valdron <mvaldron@redhat.com> Co-authored-by: Maysun Faisal <31771087+maysunfaisal@users.noreply.github.com> Co-authored-by: Lucas Yoon <94267691+JslYoon@users.noreply.github.com> Co-authored-by: Michael Valdron <mvaldron@redhat.com>
Jdubrick
added a commit
that referenced
this pull request
Feb 10, 2026
* Conditionally Add All Inference Providers (#12) * add all providers conditionally Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add vertex ai provider Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * [RHDHPAI-1170] Add Question Validation Prompt Template Sync Script (#11) * add python script for syncing contents Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add CI for running validation on PRs Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add make commands for running script Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * run the sync with upstream prompt templates Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * cleanup whitespace Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update rag items to 1.8 (#13) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * bump latest version in readme Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * Update build commands readme.md, add cache info for local run in lightspeed-stack.yaml (#16) Signed-off-by: Lucas <lyoon@redhat.com> * [RHIDP-10054] Add YAML Formatter (#17) * v0.0.0 * add Prettier for formatting and update docs Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * resolve conflict and reformat Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add default for vllm envs (#18) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * Konflux onboarding prep work (#19) * add license Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add license headers Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add build step to add license file into container image Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix image tags and digests Signed-off-by: Michael Valdron <mvaldron@redhat.com> * run second build instruction as root Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add enterprise contract labels for llama stack to image build Signed-off-by: Michael Valdron <mvaldron@redhat.com> * ignore existance errors from creating /license directory during image build Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix user switching order Signed-off-by: Michael Valdron <mvaldron@redhat.com> * include additional instructions about accessing host model server Signed-off-by: Michael Valdron <mvaldron@redhat.com> * feedback: remove extra descriptor for running locally Signed-off-by: Michael Valdron <mvaldron@redhat.com> * feedback: bump project version to match latest release version Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add troubleshooting section (#20) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update prompt template (#22) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * [RHIDP-11190] Update Llama Stack To 0.3.5 (#24) * move to llama stack 0.3.4 and remove safety shield Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update readme with 0.3 info Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update lightspeed provider tag (could become redundant) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update llama stack to 0.3.5 Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update run.yaml to llama v0.3.x standard Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update mount reference to use 'rag-content' Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add llama guard Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * overhaul readme Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update no guard run Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * use experimental 1.8 rag build Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update deployment doc (#25) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * prepare for 0.1.3 release Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update version in containerfile Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> Signed-off-by: Lucas <lyoon@redhat.com> Signed-off-by: Michael Valdron <mvaldron@redhat.com> Co-authored-by: Maysun Faisal <31771087+maysunfaisal@users.noreply.github.com> Co-authored-by: Lucas Yoon <94267691+JslYoon@users.noreply.github.com> Co-authored-by: Michael Valdron <mvaldron@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Which issue(s) this PR fixes:
N/A
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: