Repository navigation
Incorrect behavior of DowngradeAttributeToAnnotationRector #9355
Description
Activity
Re-open, it cause error on downgrade, seems due to reprinting single line, ref https://github.com/rectorphp/rector-src/actions/runs/17532914306/job/49817300076#step:14:70
@kkmuffme I tried 2 times handle it on rector side, see PR:
- [DowngradePhp80] Register Override and SensitiveParameter to skipped attributes on DowngradeAttributeToAnnotationRector rector-downgrade-php#318
- Re-skip Override and SensitiveParameter rector-downgrade-php#320
but it keep cause our rector-src issues, see:
- https://github.com/rectorphp/rector-src/actions/runs/17532914306/job/49817300076#step:14:70
- https://github.com/rectorphp/rector-src/actions/runs/17532914306/job/49825764897
so we seems can't handle it, this probably a bug on
humbug/php-scoperYou may need to create reproducible code and report there. If it fixed there, we may then can re-skip the Override and SensitiveParameter here :)
Thank you for understanding.
This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.
- locked as resolved and limited conversation to collaborators
on Feb 8, 2026
Bug Report
Minimal PHP Code Causing Issue
See https://getrector.com/demo/9ddd11a3-9f6a-411f-802a-b6420d7e9b53
Responsible rules
DowngradeAttributeToAnnotationRectorExpected Behavior
attributes that do not have a corresponding annotation should not be changed instead of being removed completely, as otherwise information is lost (and annotations are just regular code comments in older PHP versions anyway, so there's no reason to completely remove them)
EDIT: at least for non-param annotations, since those need to be removed in all cases, e.g. https://getrector.com/demo/6ae7b65b-69e7-4d2c-b390-1961698831df is correct
this rector should not modify code it does not even touch - e.g. why does it remove the empty line between
}andreturn '10';or move the{of the function declaration to the next line? These are all unrelated to the annotation and shouldn't be modified