Conversation
Should hopefully fix the issue where some users would get incorrect controller mapping/spinning camera. Also allows hotswapping controllers, and fixes two issues with vibration: 1. High/Low frequency vibration variables were swapped (probably the real cause of #24, the motor used the most by the game is the strongest one and we were incorrectly using the weaker one) 2. Vibration was not working after hotswapping 3. Vibration now runs in the main thread (should be more accurate)
Owner
Author
|
@Nucleoprotein Are you okay? Would you like to review this? |
rebtd7
commented
Aug 16, 2021
Comment on lines
+182
to
+186
| // TODO Move this somewhere else... | ||
| // I've tried to move it to hkIDirect3D9::ApplyCreateDeviceFix but I got an incorrect ref count error message in the log (why?) | ||
| IDirect3DSwapChain9* swapChain = NULL; | ||
| HRESULT getSwapChainResult = pIDirect3DDevice9->GetSwapChain(0, &swapChain); | ||
| context.HookPresent(&swapChain); |
Collaborator
There was a problem hiding this comment.
I'm back in home but i need to catch up with work. I will check this when i have some time.
Owner
Author
There was a problem hiding this comment.
No problem, there's no rush. Glad to hear you are back home!
|
Is this PR still under review? This would fix a rather large issue with the game. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should hopefully fix the issue where some users would get incorrect controller mapping/spinning camera.
https://steamcommunity.com/app/292120/discussions/0/4312743731808007161/
https://steamcommunity.com/app/292120/discussions/0/613938693134914508/
https://steamcommunity.com/app/292120/discussions/0/3047230236583754130/
https://steamcommunity.com/app/292120/discussions/1/3047231300180681161/
https://steamcommunity.com/app/292120/discussions/0/141136086923284332/
Also allows hotswapping controllers without any slowdown, and fixes two issues with vibration:
High/Low frequency vibration variables were swapped (probably the real cause of Vibration Strength #24, the motor used the most by the game is the strongest one and we were incorrectly using the weaker one)
Vibration was not working after hotswapping
Vibration also now runs in the main thread (should be more accurate)