feat: add resilient native cold-start update checks

.github/workflows/test.yml

@@ -57,3 +57,9 @@ jobs:
             -lpthread \
             -o unit_test
           ./unit_test
+
+      # Golden-vector parity between src/updateFlowCore.ts (reference) and
+      # the cpp/update_flow_core port. The vectors themselves are kept in
+      # sync with the TS side by src/__tests__/flowVectors.test.ts (js-test).
+      - name: Replay flow golden vectors against the C++ port
+        run: SANITIZE=1 ./scripts/test-update-flow-core.sh

android/jni/Android.mk

@@ -10,7 +10,8 @@ LOCAL_C_INCLUDES := \
 	$(LOCAL_PATH)/HDiffPatch \
 	$(LOCAL_PATH)/HDiffPatch/libHDiffPatch/HPatch \
 	$(LOCAL_PATH)/lzma/C \
-	$(LOCAL_PATH)/../../cpp/patch_core
+	$(LOCAL_PATH)/../../cpp/patch_core \
+	$(LOCAL_PATH)/../../cpp/update_flow_core
 
 Hdp_Files := \
 	hpatch.c \
@@ -28,6 +29,9 @@ LOCAL_SRC_FILES := \
 	../../cpp/patch_core/patch_core_android.cpp \
 	../../cpp/patch_core/state_core.cpp \
 	../../cpp/patch_core/update_core_android.cpp \
+	../../cpp/update_flow_core/flow_json.cpp \
+	../../cpp/update_flow_core/update_flow_core.cpp \
+	../../cpp/update_flow_core/update_flow_jni.cpp \
 	$(Hdp_Files)
 
 include $(BUILD_SHARED_LIBRARY)

android/src/main/java/cn/reactnative/modules/update/DownloadTask.java

@@ -107,14 +107,29 @@ private void downloadFile() throws IOException {
         this.hash = params.hash;
         String url = params.url;
         File writePath = params.targetFile;
-        UpdateFileUtils.ensureParentDirectory(writePath);
         Request request = new Request.Builder().url(url).build();
 
+        OkHttpClient requestClient = HTTP_CLIENT;
+        if (params.deadlineNanos > 0) {
+            long remainingNanos = params.deadlineNanos - System.nanoTime();
+            if (remainingNanos <= 0) {
+                throw new IOException("Download deadline expired before start");
+            }
+            long remainingMillis = Math.max(
+                1L,
+                java.util.concurrent.TimeUnit.NANOSECONDS.toMillis(remainingNanos)
+            );
+            requestClient = HTTP_CLIENT.newBuilder()
+                .callTimeout(remainingMillis, java.util.concurrent.TimeUnit.MILLISECONDS)
+                .build();
+        }
+
+        UpdateFileUtils.ensureParentDirectory(writePath);
         if (writePath.exists() && !writePath.delete()) {
             throw new IOException("Failed to replace existing file: " + writePath);
         }
 
-        try (Response response = HTTP_CLIENT.newCall(request).execute()) {
+        try (Response response = requestClient.newCall(request).execute()) {
             if (!response.isSuccessful()) {
                 throw new IOException("Server error: " + response.code() + " " + response.message());
             }
@@ -418,32 +433,53 @@ private boolean isPatchTask(int taskType) {
             || taskType == DownloadTaskParams.TASK_TYPE_PATCH_FROM_PPK;
     }
 
+    private boolean hasCompletedPatchDirectory() {
+        return params.unzipDirectory != null
+            && new File(params.unzipDirectory, "index.bundlejs").isFile()
+            && new File(
+                params.unzipDirectory,
+                UpdateContext.VERSION_COMPLETE_FILE
+            ).isFile();
+    }
+
     @Override
     public void run() {
         int taskType = params.type;
+        final boolean alreadyCompleted = isPatchTask(taskType)
+            && hasCompletedPatchDirectory();
         try {
-            switch (taskType) {
-                case DownloadTaskParams.TASK_TYPE_PATCH_FULL:
-                    doFullPatch();
-                    break;
-                case DownloadTaskParams.TASK_TYPE_PATCH_FROM_APK:
-                    doPatchFromApk();
-                    break;
-                case DownloadTaskParams.TASK_TYPE_PATCH_FROM_PPK:
-                    doPatchFromPpk();
-                    break;
-                case DownloadTaskParams.TASK_TYPE_CLEANUP:
-                    doCleanUp();
-                    break;
-                case DownloadTaskParams.TASK_TYPE_PLAIN_DOWNLOAD:
-                    downloadFile();
-                    break;
-                default:
-                    break;
+            if (alreadyCompleted) {
+                Log.i(UpdateContext.TAG,
+                    "download task: version " + params.hash + " already completed");
+            } else {
+                switch (taskType) {
+                    case DownloadTaskParams.TASK_TYPE_PATCH_FULL:
+                        doFullPatch();
+                        break;
+                    case DownloadTaskParams.TASK_TYPE_PATCH_FROM_APK:
+                        doPatchFromApk();
+                        break;
+                    case DownloadTaskParams.TASK_TYPE_PATCH_FROM_PPK:
+                        doPatchFromPpk();
+                        break;
+                    case DownloadTaskParams.TASK_TYPE_CLEANUP:
+                        doCleanUp();
+                        break;
+                    case DownloadTaskParams.TASK_TYPE_PLAIN_DOWNLOAD:
+                        downloadFile();
+                        break;
+                    default:
+                        break;
+                }
             }
         } catch (Throwable error) {
             Log.e(UpdateContext.TAG, "download task failed", error);
-            cleanUpAfterFailure(taskType);
+            // A duplicate task must never delete a version completed by an
+            // earlier queued task. The marker + bundle pair is the ownership
+            // handoff: once present, this failure did not create that install.
+            if (!hasCompletedPatchDirectory()) {
+                cleanUpAfterFailure(taskType);
+            }
 
             if (params.listener != null) {
                 // A patch task that failed after its artifact was fully
@@ -462,6 +498,25 @@ && isPatchTask(taskType)
             return;
         }
 
+        if (isPatchTask(taskType) && !alreadyCompleted) {
+            try {
+                File marker = new File(
+                    params.unzipDirectory,
+                    UpdateContext.VERSION_COMPLETE_FILE
+                );
+                if (!marker.createNewFile() && !marker.isFile()) {
+                    throw new IOException("Failed to mark completed update: " + marker);
+                }
+            } catch (Throwable error) {
+                Log.e(UpdateContext.TAG, "failed to mark completed update", error);
+                cleanUpAfterFailure(taskType);
+                if (params.listener != null) {
+                    params.listener.onDownloadFailed(error);
+                }
+                return;
+            }
+        }
+
         // The task itself succeeded. Run the completion callback outside the
         // try/catch above so an exception thrown by the callback (e.g. a
         // FileProvider misconfiguration during installApk) is not mistaken for

android/src/main/java/cn/reactnative/modules/update/DownloadTaskParams.java

@@ -20,6 +20,9 @@ class DownloadTaskParams {
     String      originHash;
     // TASK_TYPE_CLEANUP only: entries younger than this survive; 0 = delete all
     int         maxAgeDays = 3;
+    // Absolute System.nanoTime deadline for orchestrated cold-start downloads;
+    // 0 keeps the normal public API's 10-minute per-call timeout.
+    long        deadlineNanos;
     File        targetFile;
     File        unzipDirectory;
     File        originDirectory;