Skip to content

[0.87] fix(ios): backport clear text background omission for IME underlines - #59445

Open
kurohune538 wants to merge 1 commit into
react:0.87-stablefrom
kurohune538:fix/0.87-ios-japanese-ime-underline
Open

kurohune538 wants to merge 1 commit into
react:0.87-stablefrom
kurohune538:fix/0.87-ios-japanese-ime-underline

Conversation

@kurohune538

Copy link
Copy Markdown

Summary:

Backport the production fix from #59207 to 0.87-stable and add five regression tests, following the 0.88 backport in #59432.

The default clear NSBackgroundColorAttributeName suppresses the Japanese IME composition underline even while the native marked range remains active. Omitting that no-op attribute restores the underline. Visible backgrounds and foreground/background opacity remain intact.

This is intentionally limited to the underline root cause. It does not change TextInput delegates, selection/synchronization logic, or claim to solve every CJK composition issue discussed in #56082.

Production fix by Gregory Moskaliuk (@hryhoriiK97); regression coverage adapted from the 0.88 backport by @riottt.

Related to #48497 and the underline portion of #56082.

Changelog:

[IOS] [FIXED] - Avoid a default transparent text background that can suppress the Japanese IME composition underline.

Test Plan:

  • Installed RNTester pods from source with RCT_USE_PREBUILT_RNCORE=0 bundle exec pod install --no-repo-update.
  • Locally registered RCTAttributedTextUtilsTest.mm in RNTesterUnitTests for verification; that project-only edit is excluded from this PR.
  • Ran RCTAttributedTextUtilsTest on an iPhone 17 Pro / iOS 26.5 simulator. The 0.87 branch has an unrelated compile failure in RCTTurboModuleArrayBufferTests.mm, so that source was excluded from this targeted run.
    • Before the production hunk: 14 passed / 4 failed (18 total).
    • After the production hunk: 18 passed / 0 failed.
  • The main-branch C++/Objective-C formatting checker passes on both modified files, and git diff --check passes.
  • UI evidence for the identical production hunk on 0.88: reproduction details and screenshots.

Japanese IME underline before and after

@meta-cla

meta-cla Bot commented Oct 24, 2026

Copy link
Copy Markdown

Hi @kurohune538!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Oct 24, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2026
@meta-cla

meta-cla Bot commented Oct 24, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant