Repository navigation
Conversation
Summary: Lower `ImageComponentDescriptor.h`, `ImageShadowNode.h`, `ImageProps.h`, `ImageState.h` and `ImageEventEmitter.h` in `react/renderer/components/image` from public to "for frameworks". They implement the built-in `<Image>` component and are consumed by hosts that register core components and by platform image renderers, not by app code. This matches the tiering of the `text`, `scrollview` and `root` component modules. `conversions.h` stays public and is now the only header in the `<React/Image.h>` umbrella: code generated for a component with an `ImageSource` prop includes `<React/Image.h>` and relies on its `fromRawValue(..., ImageSource &)` overload through `convertRawProp`. Changelog: [Internal] Differential Revision: D123593354
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123593354. |
|
This pull request has been merged in bf1258e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Lower
ImageComponentDescriptor.h,ImageShadowNode.h,ImageProps.h,ImageState.handImageEventEmitter.hinreact/renderer/components/imagefrom public to "for frameworks". They implement the built-in<Image>component and are consumed by hosts that register core components and by platform image renderers, not by app code. This matches the tiering of thetext,scrollviewandrootcomponent modules.conversions.hstays public and is now the only header in the<React/Image.h>umbrella: code generated for a component with anImageSourceprop includes<React/Image.h>and relies on itsfromRawValue(..., ImageSource &)overload throughconvertRawProp.Changelog: [Internal]
Differential Revision: D123593354