Repository navigation
Retier react/utils headers (#58842) - #58842
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123383902. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Pull Request resolved: react#58842 Make `Base64.h`, `Uuid.h`, `MoveWrapper.h` and `jsi-utils.h` private, and `SimpleThreadSafeCache.h`, `OnScopeExit.h`, `FloatComparison.h`, `RunLoopObserver.h`, `LowPriorityExecutor.h`, `PackTraits.h`, `TemplateStringLiteral.h` and `iequals.h` for frameworks; drop them from `<React/Utils.h>` and include them directly where they were reached through it. Guard `FollyConvert.h` as public and add it to the umbrella for Objective-C++. Changelog: [Internal] Differential Revision: D123383902
meta-codesync
Bot
changed the title
react/utils headersreact/utils headers (#58842)
j-piasecki
force-pushed
the
export-D123383902
branch
2 times, most recently
from
October 5, 2026 10:40
6359bb6 to
cc3ec7a
Compare
meta-codesync
Bot
changed the title
react/utils headers (#58842)react/utils headers
Summary: Make `Base64.h`, `Uuid.h`, `MoveWrapper.h` and `jsi-utils.h` private, and `SimpleThreadSafeCache.h`, `OnScopeExit.h`, `FloatComparison.h`, `RunLoopObserver.h`, `LowPriorityExecutor.h`, `PackTraits.h`, `TemplateStringLiteral.h` and `iequals.h` for frameworks; drop them from `<React/Utils.h>` and include them directly where they were reached through it. Changelog: [Internal] Differential Revision: D123383902
meta-codesync
Bot
changed the title
react/utils headersreact/utils headers (#58842)
j-piasecki
force-pushed
the
export-D123383902
branch
from
October 6, 2026 07:51
cc3ec7a to
9a9a69a
Compare
|
This pull request has been merged in 73f4204. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Make
Base64.h,Uuid.h,MoveWrapper.handjsi-utils.hprivate, andSimpleThreadSafeCache.h,OnScopeExit.h,FloatComparison.h,RunLoopObserver.h,LowPriorityExecutor.h,PackTraits.h,TemplateStringLiteral.handiequals.hfor frameworks; drop them from<React/Utils.h>and include them directly where they were reached through it.Changelog: [Internal]
Differential Revision: D123383902