Apply preset defaults without a Babel API - #58254
Closed
OskarEichler wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this in D118438065. |
|
This pull request has been reverted by 6306c4a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The preset's Babel-API accesses are optional, but invoking it without the Babel API still has two incomplete fallback paths:
preset()can read properties from an undefined options object, andgetPreset(code, {dev: false})receives no transform profile and silently falls back to legacy class transforms instead of the normalhermes-stabledefault.Default options to an empty object, consistently rely on that non-null invariant throughout the configuration builder, and apply
hermes-stablewhen neither explicit options norbabel.callerprovides a profile. Explicit options and caller-provided profiles retain precedence.Changelog:
[GENERAL] [FIXED] - Apply normal preset defaults when invoked without a Babel API or options object.
Test Plan:
preset()builds without options or a Babel API.hermes-stableprofile; exact baseline lowers the class to helpers.git diff --checkpass.No breaking change: explicit profiles/caller behavior are unchanged, while standalone invocation now matches the preset's documented default path.