Skip to content

Inline the last duplicate Platform.select key #58249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Inline the last duplicate Platform.select key #58249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native-babel-preset/src/__tests__/inline-platform-plugin-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,10 @@ describe('Platform.select', () => {
expect(select('{ios() { return 1; }}')).toContain('function');
});

test('uses the last definition of a duplicate key', () => {
expect(select('{ios: 1, ios: 2}')).toContain('const value=2');
});

test('does not inline computed keys', () => {
expect(select('{[key]: 1, default: 2}')).toContain('Platform.select');
});
Expand Down
4 changes: 3 additions & 1 deletion packages/react-native-babel-preset/src/inline-platform-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,9 @@ module.exports = function inlinePlatformPlugin(
key /*: string */,
fallback /*: () => Node */,
) /*: Node */ {
for (const property of objectExpression.properties) {
// Object literal evaluation keeps the last definition of a duplicate key.
for (let i = objectExpression.properties.length - 1; i >= 0; i--) {
const property = objectExpression.properties[i];
if (!t.isObjectProperty(property) && !t.isObjectMethod(property)) {
continue;
}
Expand Down
Loading