Skip to content

Don't register unused RCTTimingCls in RN iOS (#57657) #57657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christophpurrer wants to merge 1 commit into from
+2 −9
Closed

Don't register unused RCTTimingCls in RN iOS (#57657) #57657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-native/React/CoreModules/CoreModulesPlugins.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ Class RCTPlatformCls(void) __attribute__((used));
Class RCTRedBoxCls(void) __attribute__((used));
Class RCTSourceCodeCls(void) __attribute__((used));
Class RCTStatusBarManagerCls(void) __attribute__((used));
#ifndef RCT_REMOVE_LEGACY_ARCH
Class RCTTimingCls(void) __attribute__((used));
#endif
Class RCTWebSocketModuleCls(void) __attribute__((used));
Class RCTBlobManagerCls(void) __attribute__((used));

Expand Down
4 changes: 0 additions & 4 deletions packages/react-native/React/CoreModules/CoreModulesPlugins.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,6 @@ Class RCTCoreModulesClassProvider(const char *name)
return RCTStatusBarManagerCls();
}

if (name == "Timing"sv) {
return RCTTimingCls();
}

if (name == "WebSocketModule"sv) {
return RCTWebSocketModuleCls();
}
Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/React/CoreModules/RCTTiming.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,3 @@ - (void)createTimerForNextFrame:(nonnull NSNumber *)callbackID
}

@end

Class RCTTimingCls(void)
{
return RCTTiming.class;
}
Loading