fix(ios): prevent wrapped text clipping - #57535
Conversation
|
Hi @CreatlV! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Picking this up. Apparently #54260 was reverted shortly after it landed. The revert was triggered by a single internal screenshot test and the evidence points to that being an unrelated flake rather than a real regression from this change. I'll try to re-land the same fix with two additions:
I am validating it against our internal test suite before landing, I will follow up here once we have some signal. |
Summary:
Fixes #53450.
React Native can measure wrapped iOS text to a height that becomes one physical pixel too short after layout rounding. The final visual line is then clipped even though TextKit produced it.
#54260 avoided the clipping by adding an epsilon to every measured width and height, but it changed unrelated measurements and was reverted in #54510 after breaking internal tests. This change narrows the adjustment to the existing
textDidWrapsignal: wrapped text receives one extra physical pixel of height, while width and all non-wrapped measurements remain unchanged.This follows the narrower approach proposed by @douglowder in #53450 (comment).
Changelog:
[IOS] [FIXED] - Prevent the final line of wrapped text from being clipped
Test Plan:
main, including the modified source file, for the same iPhone 16 Pro / iOS 18.5 simulator destination.RCTTextLayoutManager.mm.