fix: popup container scroll due to precision

[aojunhao123]

• cherry-pick fix: popup container scroll due to precision #602 for antd v5

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @aojunhao123, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a subtle bug where popup containers could exhibit unwanted scrolling due to floating-point precision issues in their positioning calculations. By switching from Math.round to Math.floor for offset values, the change ensures more consistent and predictable placement, resolving potential visual glitches. It also includes a minor update to the .gitignore file and corresponding test adjustments to reflect the new behavior.

Highlights

• Precision Handling for Popup Positioning: Changed Math.round to Math.floor for calculating nextOffsetX, offsetX4Right, nextOffsetY, and offsetY4Bottom in useAlign.ts to prevent unexpected scroll issues caused by floating-point precision in popup positioning.
• Build Tool Configuration: Added pnpm-lock.yaml to .gitignore to ensure it is not committed to the repository.
• Test Case Update: Modified an existing test case in align.test.tsx to reflect the new Math.floor logic, specifically updating the expected top style value for a popup from 56px to 55px.
• Backport from fix: popup container scroll due to precision #602: This pull request is a cherry-pick of an existing fix (fix: popup container scroll due to precision #602) for antd v5, indicating a known issue being addressed in this version.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.76%. Comparing base (1641cc2) to head (c697f8c).
⚠️ Report is 1 commits behind head on antd-v5.

Additional details and impacted files

@@           Coverage Diff            @@
##           antd-v5     #603   +/-   ##
========================================
  Coverage    97.76%   97.76%           
========================================
  Files           13       13           
  Lines          805      805           
  Branches       234      242    +8     
========================================
  Hits           787      787           
  Misses          18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Code Review

This pull request addresses a precision issue with popup positioning that could lead to unnecessary scrollbars. The fix involves changing Math.round to Math.floor for offset calculations, which provides more predictable behavior for layout and helps prevent pixel overflow. The changes are supported by updated tests that verify the new rounding logic. Additionally, the .gitignore file is updated to include pnpm-lock.yaml, which is a good housekeeping change. The overall implementation is sound and effectively resolves the described issue.