Skip to content

[Quest Sample] Add advanced Copilot data agent content - #1

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
quest-sample-pr-20251205-173104
Open

[Quest Sample] Add advanced Copilot data agent content#1
github-actions[bot] wants to merge 1 commit into
mainfrom
quest-sample-pr-20251205-173104

Conversation

@github-actions

@github-actions github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown

Description

This PR adds comprehensive content to the implement-fabric-data-agents module, addressing learner feedback for more practical guidance on enterprise implementations.

Changes Made

New Content Files

File Description
copilot-advanced-scenarios.md Multi-turn conversations, cross-source correlation, automated insights
copilot-best-practices.md Data preparation, security config, performance optimization
copilot-troubleshooting.md Common issues, error codes, diagnostic steps

Modified Files

File Changes
index.yml Added three new units to module structure

Content Review Checklist

  • Technical accuracy verified against current Fabric capabilities
  • Code samples tested in Fabric workspace
  • Screenshots captured from current UI (November 2024)
  • Accessibility: All images have descriptive alt text
  • Terminology review: Consistent "Copilot for Microsoft Fabric" usage
  • Link validation: All xrefs and external links verified
  • Spell check completed

Module Impact

  • Current units: 7
  • After merge: 10 (3 new units added)
  • Estimated completion time change: +15 minutes

Related Issues

  • Addresses feedback from Issue #45: "Need more troubleshooting guidance"
  • Partial fix for Issue #38: "Enterprise scenarios not covered"

⚠️ This is a sample PR for Quest Scenario 2

This PR intentionally includes issues for review practice:

YAML Issues:

  • Missing colon after prerequisites in index.yml (line 20)
  • Outdated ms.date: 04/15/2024

Content Issues:

  • Typos: "avialable", "setings", "Intermitent", "occured"
  • Broken link: http://old-support.fabric.com/help
  • Inconsistent terminology: Mix of "Copilot" and "data agents"

Structural Issues:

  • Code sample uses deprecated fabric.dataagent import path
  • Missing > [!IMPORTANT] callout for security section

Use GitHub Copilot to:

  1. Review the PR with @workspace
  2. Identify content and technical issues
  3. Validate YAML structure
  4. Generate constructive feedback for the author

This is a sample PR for Quest Scenario 2. Part of GitHub Copilot Repository Management Quest for Microsoft Learn content.

This PR adds comprehensive content to the implement-fabric-data-agents module:

New content:
- Advanced scenarios unit (multi-turn, cross-source, auto-insights)
- Best practices unit (data prep, security, performance)
- Troubleshooting unit (common issues and solutions)
- Updated index.yml with new units

Addresses learner feedback requesting more practical guidance for
enterprise data agent implementations.

Related to content refresh initiative for Fabric Copilot modules.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

- Test and refine agent responses
- Implement advanced scenarios and best practices
- Troubleshoot common data agent issues
prerequisites

Copilot AI Jan 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing colon after "prerequisites". YAML syntax requires a colon to denote a key-value pair. This should be "prerequisites:" to properly define the prerequisites section.

Suggested change
prerequisites
prerequisites:

Copilot uses AI. Check for mistakes.
If your data agent isn't responding to queries:

1. Verify Fabric capacity is running and not paused
2. Check that the agent is enabled in workspace setings

Copilot AI Jan 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "setings" should be "settings".

Suggested change
2. Check that the agent is enabled in workspace setings
2. Check that the agent is enabled in workspace settings

Copilot uses AI. Check for mistakes.
|---------|--------------|----------|
| > 30s response | Large dataset scan | Add aggregation layer |
| Timeout errors | Complex joins | Simplify data model |
| Intermitent slowness | Capacity throttling | Review capacity metrics |

Copilot AI Jan 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "Intermitent" should be "Intermittent".

Suggested change
| Intermitent slowness | Capacity throttling | Review capacity metrics |
| Intermittent slowness | Capacity throttling | Review capacity metrics |

Copilot uses AI. Check for mistakes.
1. Agent ID and workspace ID
2. Exact error message or unexpected behavior
3. Sample query that reproduces the issue
4. Timestamp of when the issue occured

Copilot AI Jan 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "occured" should be "occurred".

Suggested change
4. Timestamp of when the issue occured
4. Timestamp of when the issue occurred

Copilot uses AI. Check for mistakes.
3. Sample query that reproduces the issue
4. Timestamp of when the issue occured

Contact support at [Fabric Support](http://old-support.fabric.com/help).

Copilot AI Jan 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The support URL "http://old-support.fabric.com/help" appears to be a placeholder or outdated link. Please replace this with the current official Microsoft Fabric support documentation URL.

Suggested change
Contact support at [Fabric Support](http://old-support.fabric.com/help).
Contact support at [Fabric Support](https://learn.microsoft.com/fabric/get-started/fabric-support).

Copilot uses AI. Check for mistakes.
Comment on lines +25 to +26
from fabric.dataagent import DataAgent

Copilot AI Jan 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path "fabric.dataagent" appears to be deprecated or non-standard. Based on current Microsoft Fabric SDK patterns, this should be reviewed and updated to use the current recommended import path for Fabric data agent functionality.

Suggested change
from fabric.dataagent import DataAgent
# DataAgent is provided by the Microsoft Fabric SDK in your environment.

Copilot uses AI. Check for mistakes.
Comment on lines +46 to +55
```
AGENT_001: Agent not initialized
Solution: Wait 2-3 minutes after agent creation

AGENT_002: Insufficient permissions
Solution: Grant user 'Viewer' role or higher on workspace

AGENT_003: Data source unavailable
Solution: Check lakehouse/warehouse connectivity
```

Copilot AI Jan 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block for error messages lacks a language specification. While the content appears to be plain text, according to Microsoft Learn guidelines, all code blocks should specify a language for proper syntax highlighting. Consider using "text" or "output" as the language identifier.

Copilot generated this review using guidance from repository custom instructions.
metadata:
title: Implement Fabric data agents
description: Learn how to implement and manage data agents in Microsoft Fabric for enhanced data interaction.
ms.date: 04/15/2024

Copilot AI Jan 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ms.date value "04/15/2024" is outdated. According to Microsoft Learn guidelines, the ms.date should be within the last 12 months. Please update this to a current date.

Copilot generated this review using guidance from repository custom instructions.

### Check data freshness

Data agents query the most recent data avialable. If data seems outdated:

Copilot AI Jan 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "avialable" should be "available".

Suggested change
Data agents query the most recent data avialable. If data seems outdated:
Data agents query the most recent data available. If data seems outdated:

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant