fix test compilation issues on various architectures - #46
Open
decathorpe wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple change should fix #42 - or at least it does fix the issue for me on i686, and since the failure is the same on the other 32-bit architectures, I assume this PR should also fix those. The
foo as _trick is something I've seen used in other crates that deal withlibcbindings that have different type signatures on different architectures.I've also added a setting that excludes the "ci" directory from published crates - the files in it are larger than the rest of the crate combined (including the license text!) and they are not needed when using the crate as distributed via crates.io.
This change is