Fix compilation on OpenBSD - #19
Open
realchonk wants to merge 2 commits into
Open
Conversation
This commit fixes compilation on OpenBSD by providing a stub for ulimited_memory(). The original implementation for unix doesn't work for OpenBSD, because it doesn't have RLIMIT_AS. OpenBSD does provide RLIMIT_DATA though. Signed-off-by: Benjamin Stürz <benni@stuerz.xyz>
rbtcollins
approved these changes
Nov 20, 2022
Owner
|
Thank you for this change. Master seems to be breaking on android and we need to track that down before doing a release. |
Author
Seems to be a CI configuration issue for android. Same with freebsd. |
Owner
|
Yah; I've fixed FreeBSD now, but still not sure whats up with Android |
rbtcollins
requested changes
Nov 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation on OpenBSD by providing a stub for
ulimited_memory().The original implementation for unix doesn't work for OpenBSD, because it doesn't have
RLIMIT_AS.OpenBSD does provide
RLIMIT_DATAthough.Signed-off-by: Benjamin Stürz benni@stuerz.xyz
This change is