Skip to content

Conversation

@reebhub
Copy link
Contributor

@reebhub reebhub commented Jan 14, 2026

related issue:
RDoc-3620

@reebhub reebhub requested a review from poissoncorp January 14, 2026 02:19
@poissoncorp
Copy link
Contributor

@reebhub there are build errors - could you check them?

@reebhub
Copy link
Contributor Author

reebhub commented Jan 14, 2026

@poissoncorp just warnings that non C# page headers will be ignored because they are taken from the switcher doc in the root folder. fixed.

### Set chat trimming configuration

To [summarize the conversation](../../../ai-integration/ai-agents/overview#define-a-chat-trimming-configuration), create an `AiAgentChatTrimmingConfiguration` instance,
use it to configure your trimming strategy, and set the agent's `ChatTrimming` property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use it to configure your trimming strategy, and set the agent's `ChatTrimming` property
use it to configure your trimming strategy, and set the agent's `chat_trimming` property

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


* **Example**
Set a query tool that runs when the agent is started and retrieves all the orders sent everywhere.
```csharp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```csharp
```python

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the sample below isn't written in Python

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the sample missing?

Copy link
Contributor Author

@reebhub reebhub Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you reported that AiAgentToolQueryOptions can't be found in the python repository and you intend to create it, so the "initial-context queries" section is currently commented out and the content untouched, including the type (csharp, not python), text and sample.

runs before the conversation starts, earlier than the first communication with the LLM, and the LLM will have no opportunity to fill the parameters with values.
* An initial-context query **is** allowed to use agent parameters, whose values are provided by the user even before the query is executed.

* You can use the `Options.AllowModelQueries` property to Enable or Disable a query tool .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* You can use the `Options.AllowModelQueries` property to Enable or Disable a query tool .
* You can use the `options.allow_model_queries` property to Enable or Disable a query tool .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also related to initial-context queries, waiting for the missing AiAgentToolQueryOptions

* When a query tool is enabled, the LLM can freely trigger its execution.
* When a query tool is disabled, the LLM cannot trigger its execution.
* If a query tool is set as an initial-context query, it will be executed when the conversation
starts even if disabled using `AllowModelQueries`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
starts even if disabled using `AllowModelQueries`.
starts even if disabled using `allow_model_queries`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no sample here yet


* **Syntax**
```csharp
public class AiAgentToolQueryOptions : IDynamicJson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here - was the Python sample missing for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you didn't find it in the python repository, there's no sample for this section

@ppekrol ppekrol merged commit 9206de3 into ravendb:main Jan 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants