Add supply-chain quality helpers - #1781
Draft
simple-agent-manager[bot] wants to merge 2 commits into
Draft
Conversation
|
simple-agent-manager
Bot
force-pushed
the
sam/coordinate-implement-deterministic-runtime-gkq1xt
branch
from
August 10, 2026 18:59
5863929 to
86be87c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
scripts/quality/only.Validation
pnpm lintpnpm typecheckpnpm test— focused impacted suite below.claude/rules/47-control-loop-io-budget.md) — N/A: helper-only policy code, no production sweep/cron query is wired.Additional validation:
pnpm exec vitest run --config scripts/quality/vitest.config.ts scripts/quality/check-direct-dependency-evidence.test.ts scripts/quality/check-go-vulnerability-diff.test.ts scripts/quality/check-osv-policy.test.ts scripts/quality/check-secret-scan-policy.test.ts— PASS, 4 files / 14 tests.pnpm exec prettier --check ...new supply-chain files...— PASS.pnpm exec tsx --check scripts/quality/check-direct-dependency-evidence.ts— PASS.pnpm exec tsx --check scripts/quality/check-go-vulnerability-diff.ts— PASS.pnpm exec tsx --check scripts/quality/check-osv-policy.ts— PASS.pnpm exec tsx --check scripts/quality/check-secret-scan-policy.ts— PASS.pnpm quality:dependency-governance— PASS, existing dependency-governance suite.pnpm quality:scripts:test— ATTEMPTED twice; new tests passed, but existing timeout-prone tests failed outside this diff (check-no-tracked-stale-binaries.test.ts,check-migration-ordering.test.ts).Staging Verification (REQUIRED for all code changes — merge-blocking)
All checkboxes below are mandatory for any PR that changes runtime code (
.ts,.tsx,.go, etc.). WriteN/A: docs-onlyONLY if the PR contains zero runtime code changes. See.claude/rules/13-staging-verification.md.Staging Verification Evidence
Staging intentionally skipped. The user explicitly instructed: never deploy staging. This PR adds local quality helper scripts only and does not change application runtime paths.
UI Compliance Checklist (Required for UI changes)
End-to-End Verification (Required for multi-component changes)
.claude/rules/10-e2e-verification.md) — N/A: quality-helper-only library/CLI functions; no user input or app backend path.scripts/quality/vitest.config.ts, CI quality script test wiring, dependency-governance tests, PR template, constitution, and active task record reviewed.Data Flow Trace
N/A: helper-only scripts. The relevant local flows are:
scripts/quality/check-direct-dependency-evidence.tsparses unified diffs, extracts production direct additions frompackage.json/go.mod, excludes updates/removals/dev/workspace/internal dependencies, then validatesscripts/quality/direct-dependency-evidence.jsonentries.scripts/quality/check-go-vulnerability-diff.tsaccepts changed file lists, runs injectablegovulncheck ./...only whengo.modorgo.sumchanged, and cannot match unrelated filenames such asgo.mod-notes.md.scripts/quality/check-secret-scan-policy.tsevaluates synthetic Gitleaks JSON findings, fails closed on findings, and removesSecret/Matchvalues from result payloads.scripts/quality/check-osv-policy.tstreats PR events as non-advisory, validates scheduled/workflow-dispatch advisory runs require private SAM/backlog routing, and requires every ignore to have reason plus future expiry.Untested Gaps
Coordinator wiring is intentionally unimplemented in this child PR. The helpers are not added to
package.json, CI workflows, PR template, or shared integration configs due to exclusive ownership constraints.Post-Mortem (Required for bug fix PRs)
N/A: not a bug fix.
What broke
N/A.
Root cause
N/A.
Class of bug
N/A.
Why it wasn't caught
N/A.
Process fix included in this PR
N/A.
Post-mortem file
N/A.
Specialist Review Evidence (Required for agent-authored PRs)
needs-human-reviewlabel added and merge deferred to human — N/A.scripts/quality/**families added; coordinator wiring left explicit.Secret/Matchfields, tests use synthetic non-secret values, no full-history scans run or encoded in defaults.Exceptions (If any)
Agent Preflight (Required)
Classification
External References
N/A: no external API integration; helper behavior designed from repository task/instructions and existing quality-script conventions.
Codebase Impact Analysis
Affected paths are limited to
scripts/quality/check-direct-dependency-evidence*,scripts/quality/check-go-vulnerability-diff*,scripts/quality/check-osv-policy*,scripts/quality/check-secret-scan-policy*,scripts/quality/direct-dependency-evidence.json, andscripts/quality/fixtures/supply-chain/**.Documentation & Specs
N/A: no public docs/spec updates. Coordinator wiring/blocker is documented in this PR body.
Constitution & Risk Check
Checked constitution Principle XI and relevant security/quality rules. Key risk is false positives from over-broad applicability; tests cover PR event non-applicability for OSV and exact Go module filename matching for govulncheck. Key privacy risk is secret echo in scan output; tests assert synthetic finding values are absent from returned/loggable structures.