Skip to content

update release process and remove safety from ci #559

Merged
joshdimanteto merged 5 commits into
mainfrom
develop
May 22, 2026
Merged

update release process and remove safety from ci #559
joshdimanteto merged 5 commits into
mainfrom
develop

Conversation

@joshdimanteto
Copy link
Copy Markdown
Contributor

Description

see #558

Testing Instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?
  • {more steps here}

Agile Board Tracking

Closes #555 , Closes #557

@joshdimanteto joshdimanteto marked this pull request as ready for review May 22, 2026 15:03
@joshdimanteto joshdimanteto changed the title Develop updat release changes and remove safety from ci May 22, 2026
@joshdimanteto joshdimanteto changed the title updat release changes and remove safety from ci update release process and remove safety from ci May 22, 2026
Copy link
Copy Markdown

@patrick-austin patrick-austin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commits either merges not affecting any change or already approved on #558

@joshdimanteto joshdimanteto merged commit d5f5f86 into main May 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the release process Remove safety from CI jobs

2 participants