Support Indonesian number format in transaction amounts - #26
Conversation
Updated `_AMOUNT_PATTERN` in `pdfparser/utils.py` to support both US (dot decimal) and Indonesian (comma decimal) currency formats. Added regression tests in `tests/test_transaction_extraction.py`. Co-authored-by: rager306 <248269686+rager306@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WalkthroughModified the amount pattern regex to support Indonesian number formatting (dots for thousands, comma for decimal) alongside standard decimal notation. Added comprehensive unit tests to validate transaction extraction with both format variants and missing user ID scenarios. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Updated the regex pattern for transaction amounts to correctly identify numbers with comma decimal separators (Indonesian format) while maintaining support for dot decimal separators (US format). Added a new test file to verify transaction extraction for both formats.
PR created automatically by Jules for task 12851599774878756901 started by @rager306
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.