fix: support Indonesian currency format and fix NoneType error in pdfoxide parser - #23
fix: support Indonesian currency format and fix NoneType error in pdfoxide parser#23rager306 wants to merge 1 commit into
Conversation
…oxide parser - Update `_AMOUNT_PATTERN` in `pdfparser/utils.py` to support Indonesian currency format (comma decimal). - Fix potential `TypeError` in `pdfparser/pdfoxide_parser.py` when `extract_text` returns `None`. - Add tests for Indonesian and US currency formats in `tests/test_utils.py`. Co-authored-by: rager306 <248269686+rager306@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WalkthroughThis PR fixes a potential None handling issue in PDF text extraction and extends monetary value parsing to support both US and Indonesian number formats. Two test cases validate the locale-aware number parsing functionality. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR addresses two issues:
_AMOUNT_PATTERNonly supported US format (dot decimal), causing Indonesian amounts (comma decimal) to be misidentified or ignored. It has been updated to support both.pdfoxideparser could raise aTypeErrorifextract_textreturnedNone, as the fallbackor ""was effectively commented out by atype: ignorecomment. This has been fixed to ensure safe string concatenation.Tests have been added to verify the fix for Indonesian amounts, and existing tests pass.
PR created automatically by Jules for task 1786048993213094149 started by @rager306
Summary by CodeRabbit
Bug Fixes
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.