fix: filter out pxe interfaces not phyiscally connected to a switch#1842
Open
fix: filter out pxe interfaces not phyiscally connected to a switch#1842
Conversation
RSabounds
reviewed
Mar 18, 2026
python/ironic-understack/ironic_understack/port_bios_name_hook.py
Outdated
Show resolved
Hide resolved
RSabounds
previously approved these changes
Mar 19, 2026
Contributor
RSabounds
left a comment
RSabounds
left a comment
There was a problem hiding this comment.
LGTM.
Handles the case with a speed_mbps available entry first, falls back to first interface, and fails with log.error().
RSabounds
dismissed
their stale review
will pend for approval post-dev env configuration. Noted that there isn't a separate UC member approval.
andrrax
force-pushed
the
inspection_pxe_interfaces
branch
from
dd4b3aa to
77d029d
Compare
stevekeay
approved these changes
Mar 19, 2026
Contributor
stevekeay
left a comment
stevekeay
left a comment
There was a problem hiding this comment.
I would add a couple of LOG.info so we can see which path it took and why.
I ran this and it worked, however on the box that I used all the interface speeds were reading zero. I suspect this was because the power was off. So that would be another fundamental issue with this approach - inspection can happen while the box is powered down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is intended to filter out interfaces which are not physically connected to a switch. Currently we're returning the first interface with a matching prefix, regardless of if there is a physically connection to the switch or not, and then configuring that Ironic Port for PXE.