feat(understack_workflows): refactor LIF creation to be more dynamic#1830
Merged
feat(understack_workflows): refactor LIF creation to be more dynamic#1830
Conversation
cardoe
force-pushed
the
netapp-app-abstract-bcast-domain
branch
4 times, most recently
from
e53b3b9 to
fcbc395
Compare
skrobul
approved these changes
Mar 17, 2026
Collaborator
skrobul
left a comment
skrobul
left a comment
There was a problem hiding this comment.
LGTM, although I am not sure if we really should cave in and allow configuration drift. Is there any legitimate reason not to have them called Fabric-A and Fabric-B ?
Contributor
Author
They probably should be. I'll tell him to fix it. |
The broadcast_domain_name could not be hard coded. What we really want is to create home ports and the LIFs bound to those home ports based on the node and the ports that the data traffic is routing over. This takes those two items as input and then makes the rest dynamically looked up from there while returning detailed exceptions when things are missing or incorrect.
Configure the NetApp SVM root volume based on the recommendations of the NetApp OpenStack Cinder guide by making it small and purposeful with the ability to grow and disable snapshots on it.
cardoe
force-pushed
the
netapp-app-abstract-bcast-domain
branch
from
d8033e6 to
1f14781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broadcast_domain_name could not be hard coded. What we really want
is to create home ports and the LIFs bound to those home ports based on
the node and the ports that the data traffic is routing over. This takes
those two items as input and then makes the rest dynamically looked up
from there while returning detailed exceptions when things are missing
or incorrect.