feat(cinder): Multi-FlexVol routing for NetApp NVMe driver by nidzrai · Pull Request #1800 · rackerlabs/understack

nidzrai · 2026-03-12T10:18:10Z

Extended the dynamic NetApp NVMe Cinder driver to support multiple FlexVols per SVM, enabling per-volume-type storage routing within a single project's SVM. https://github.com/RSS-Engineering/undercloud-deploy/pull/1463/changes

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

cardoe · 2026-03-16T16:26:19Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

 # We use a + because of the special meaning of # in
 # cinder/volume/volume_utils.py extract_host()
 _SVM_NAME_DELIM = "+"
+_FLEXVOL_PREFIX = "vol_"


We shouldn't hardcode this. Instead netapp_pool_name_search_pattern is the config option that we should use. https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/netapp-volume-driver.html

We'd define this as netapp_pool_name_search_pattern = vol_(.+)

cardoe · 2026-03-16T16:28:07Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

        pool["netapp_vserver"] = svm_name
        prefix = self.configuration.safe_get("netapp_vserver_prefix")
-        pool["netapp_project_id"] = svm_name.replace(prefix, "")
+        svm_uuid = svm_name.removeprefix(prefix)


Suggested change

svm_uuid = svm_name.removeprefix(prefix)

project_uuid = svm_name.removeprefix(prefix)

cardoe · 2026-03-16T16:28:19Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

        prefix = self.configuration.safe_get("netapp_vserver_prefix")
-        pool["netapp_project_id"] = svm_name.replace(prefix, "")
+        svm_uuid = svm_name.removeprefix(prefix)
+        pool["netapp_project_id"] = svm_uuid


Suggested change

pool["netapp_project_id"] = svm_uuid

pool["netapp_project_id"] = project_uuid

nidzrai · 2026-03-16T18:25:28Z

https://github.com/RSS-Engineering/undercloud-deploy/pull/1463/changes for netapp_pool_name_search_pattern = vol_(.+)

cardoe

We need to crank the logging down in the default case by a lot. Even some of these logs will probably need to be removed even further. The logs are just so noisy at this point and this will add more.

cardoe · 2026-03-17T01:39:40Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

-        # Get the current SVMs from cluster
        current_svms = set(self._get_svms())
-        LOG.info("Current SVMs detected from cluster: %s", current_svms)
+        LOG.info(


Suggested change

LOG.info(

LOG.debug(

cardoe · 2026-03-17T01:39:53Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

@@ -260,12 +262,13 @@ def _refresh_svm_libraries(self):
    def _actual_refresh_svm_libraries(self, ctxt):
        """Refresh the SVM libraries."""
        LOG.info("Start refreshing SVM libraries")


Suggested change

LOG.info("Start refreshing SVM libraries")

LOG.debug("Start refreshing SVM libraries")

cardoe · 2026-03-17T01:40:12Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

    def check_for_setup_error(self):
        """Check for setup errors."""
        svm_to_init = set(self._libraries.keys())
+        LOG.info(


Suggested change

LOG.info(

LOG.debug(

cardoe · 2026-03-17T01:40:27Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

            svm_lib = self._libraries[svm_name]
            try:
                svm_lib.check_for_setup_error()
+                LOG.info("SVM %s setup check passed", svm_name)


Suggested change

LOG.info("SVM %s setup check passed", svm_name)

LOG.debug("SVM %s setup check passed", svm_name)

cardoe · 2026-03-17T01:40:35Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

                LOG.exception("Failed to initialize SVM %s, skipping", svm_name)
                self._remove_svm_lib(svm_lib)
                del self._libraries[svm_name]
+        LOG.info(


Suggested change

LOG.info(

LOG.debug(

cardoe · 2026-03-17T01:45:36Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

            )
-            svm_name = f"os-{volume['project_id']}"
+
+        LOG.info(


Suggested change

LOG.info(

LOG.debug(

cardoe · 2026-03-17T01:45:47Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

            )

        volume["host"] = original_host.replace(f"{svm_name}{_SVM_NAME_DELIM}", "")
+        LOG.info(


Suggested change

LOG.info(

LOG.debug(

cardoe · 2026-03-17T01:45:56Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py


    def create_volume(self, volume):
        """Create a volume."""
+        LOG.info(


Suggested change

LOG.info(

LOG.debug(

cardoe · 2026-03-17T01:46:05Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py


    def delete_volume(self, volume):
        """Delete a volume."""
+        LOG.info(


Suggested change

LOG.info(

LOG.debug(

cardoe · 2026-03-17T01:46:26Z

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

        else:
-            return svm_filter
+            result = combined
+        LOG.info("get_filter_function: filter=%s", result)


Suggested change

LOG.info("get_filter_function: filter=%s", result)

LOG.debug("get_filter_function: filter=%s", result)

nidzrai changed the title ~~debug: add startup diagnostics and vol_type_id UUID normalization probe~~ test: add startup diagnostics and vol_type_id UUID normalization probe Mar 12, 2026

nidzrai force-pushed the cinder_for_multivol branch 2 times, most recently from e426433 to d450956 Compare March 16, 2026 14:03

nidzrai changed the title ~~test: add startup diagnostics and vol_type_id UUID normalization probe~~ feat(cinder): Multi-FlexVol routing for NetApp NVMe driver Mar 16, 2026

nidzrai force-pushed the cinder_for_multivol branch 2 times, most recently from 8ff7a63 to 6cd71a3 Compare March 16, 2026 16:15

cardoe reviewed Mar 16, 2026

View reviewed changes

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py Show resolved Hide resolved

cardoe reviewed Mar 16, 2026

View reviewed changes

nidzrai force-pushed the cinder_for_multivol branch 4 times, most recently from d98bf3e to 60010e8 Compare March 16, 2026 18:00

nidzrai requested a review from cardoe March 16, 2026 18:22

cardoe reviewed Mar 17, 2026

View reviewed changes

nidzrai force-pushed the cinder_for_multivol branch from 60010e8 to 449a7d6 Compare March 17, 2026 10:31

multi-flex driver for netapp cinder routing

68973b9

nidzrai force-pushed the cinder_for_multivol branch from 449a7d6 to 68973b9 Compare March 17, 2026 10:36

nidzrai requested a review from cardoe March 17, 2026 10:37

nidzrai added 2 commits March 17, 2026 19:26

Merge branch 'main' into cinder_for_multivol

d7e0c39

Merge branch 'main' into cinder_for_multivol

adfe477

cardoe approved these changes Mar 17, 2026

View reviewed changes

cardoe added this pull request to the merge queue Mar 17, 2026

Merged via the queue into main with commit f0f390c Mar 17, 2026
62 checks passed

cardoe deleted the cinder_for_multivol branch March 17, 2026 20:19

	svm_uuid = svm_name.removeprefix(prefix)
	project_uuid = svm_name.removeprefix(prefix)

	pool["netapp_project_id"] = svm_uuid
	pool["netapp_project_id"] = project_uuid

	LOG.info("Start refreshing SVM libraries")
	LOG.debug("Start refreshing SVM libraries")

	LOG.info("SVM %s setup check passed", svm_name)
	LOG.debug("SVM %s setup check passed", svm_name)

	LOG.info("get_filter_function: filter=%s", result)
	LOG.debug("get_filter_function: filter=%s", result)

Conversation

nidzrai commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nidzrai commented Mar 16, 2026

Uh oh!

cardoe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nidzrai commented Mar 12, 2026 •

edited

Loading