Fix Scene docking layout after Skin Finder was added#72
Open
xmx-emm wants to merge 1 commit into
Open
Conversation
DockBuilder::Window() called DockBuilderAddNode() on every root Window(). AddNode removes the existing dockspace first, so docking Skin Finder after Scene wiped Scene's dock assignment and left the preview floating (with NoMove still blocking drag). Create the dockspace once, dock side panels before the central windows, lock the central node with NoUndocking, and drop the Scene NoMove workaround. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DockBuilder::Window()was callingDockBuilderAddNode()on every root-level window.AddNoderemoves the existing dockspace first, so docking Skin Finder after Scene wiped Scene's dock assignment and left the preview floating (whileNoMovestill blocked dragging it back into place).NoUndocking.ImGuiWindowFlags_NoMoveworkaround; the central node lock matches the original intent of keeping the preview fixed in the center.Test plan
imgui.ini): Asset List left, Asset Info right, Scene centered