Use new node based routing table for routing decisions#6163
Open
nadav-govari wants to merge 2 commits intonadav/feature-node-based-routingfrom
Open
Use new node based routing table for routing decisions#6163nadav-govari wants to merge 2 commits intonadav/feature-node-based-routingfrom
nadav-govari wants to merge 2 commits intonadav/feature-node-based-routingfrom
Conversation
nadav-govari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hooks up the newly added node based routing table to be used for routing decisions instead of the existing shard based one.
Removes the subscriptions for shard position updates and local shard updates from the ingesters as they're no longer needed.
The old routing table and protos need to be cleaned up. That will be in a followup PR after this one.
How was this PR tested?
Unit tests and tested on the dogfooding cluster. Works well, and routing works correctly. Cluster is stable until the point where WALs fill up.