Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a .geminiignore file to specify file patterns that the Gemini CLI should ignore. The initial version adds a pattern for Emacs versioned backup files. My review identifies a misleading comment explaining the new pattern. The comment incorrectly states that a different pattern (*~) should have covered these files, which is not how glob patterns work and could cause confusion for future maintainers. I've suggested a correction to clarify why the new pattern is necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell Gemini CLI what it should or should not ignore. Takes precedence over
.gitignore(which Gemini CLI also reads). This PR adds only one pattern for now: a pattern that Gemini CLI does not seem to handle correctly based on.gitignorealone.