fix(cli): run update installer silently - #1352
Open
MAN$I VERMA (mansiverma897993) wants to merge 1 commit into
Open
fix(cli): run update installer silently#1352MAN$I VERMA (mansiverma897993) wants to merge 1 commit into
MAN$I VERMA (mansiverma897993) wants to merge 1 commit into
Conversation
Signed-off-by: mansiverma897993 <vmansi756@gmail.com>
Contributor
|
Hi MAN$I VERMA (@mansiverma897993) This looks great! Thanks for your work . |
Mengsheng Wu (mengshengwu)
requested changes
Aug 17, 2026
Contributor
There was a problem hiding this comment.
We rely real update test instead of text matching, So I think this tests code is unnecessary
| return nil | ||
| } | ||
|
|
||
| func updateInstallerCmd(dst string) *exec.Cmd { |
Contributor
There was a problem hiding this comment.
Only once call, so just inline it.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| func updateInstallerCmd(dst string) *exec.Cmd { | ||
| return exec.Command(dst, "/VERYSILENT", "/SUPPRESSMSGBOXES", "/NORESTART") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the Windows installer silently from geniex update so upgrades work in headless/CI environments without pop-up windows. The setup script uninstalls the previous version with no UI as well.
Closes #1344
Test plan