[ROCm][CI] Switch ROCm CI runner label from gfx942 to ecosystem.mi350 - #1524
Conversation
|
|
|
@akashveramd, why are you making this change? @jithunnair-amd, is this appropriate? |
@scotts: There was an ask from Meta to transition from linux.rocm.gpu.gfx942.1 label as it's a retired runner label. Ivan Zaitsev [10:08 PM] 1 pytorch/FBGEMM .github/workflows/fbgemm_gpu_ci_rocm.yml:164 |
|
@scotts The ROCm job scheduled on the MI350 runner but timed out when building PyTorch. I took a look at the history of the workflow/job and it last succeeded on Jun 24. That means there's a different issue that needs to be resolved, regardless of runner label. Most likely it's to do with making sure the PyTorch build from source completes within the allotted time, which probably needs some tweaking from a caching perspective or GFX archs etc. @akashveramd can look into that more. Meanwhile, can we please merge this PR so we can remove dependency on the MI300 runners that we are capacity-constrained on? |
Includes the following commits: - Fix a ConfigLoaderTest flake and three poll-thread bugs it uncovered (pytorch/kineto#1531) 2d7d08c - Make TempTraceFile work on Windows (pytorch/kineto#1529) 7a3c154 - [Kineto] Add a couple of PM Sampling API fixes (pytorch/kineto#1532) e3c84e7 - [ROCm][CI] Switch ROCm CI runner label from gfx942 to ecosystem.mi350 (pytorch/kineto#1524) db2d1a6 - [Kineto] Wire CUPTI PM Sampling up to output json and register it as a child profiler (pytorch/kineto#1530) e8f56bd - [Kineto] Enable registering CUPTI PM sampling as a child profiler (pytorch/kineto#1527) c402470 - Let Kineto install its unit test binaries (pytorch/kineto#1528) d9c6b2d - [Kineto] Refactor CUPTI timestamp handling (pytorch/kineto#1526) 55df55f - [Kineto] Kineto-native CUPTI PM sampling API (pytorch/kineto#1512) fe02f0c Pull Request resolved: #193172 Approved by: https://github.com/ryanzhang22, https://github.com/Skylion007
This PR replaces gfx942 label with ecosystem.mi350 label.