Remove eager CUPTI resource callback subscription (#1250) - #1250
Open
sanrise wants to merge 1 commit into
Open
Conversation
sanrise
added a commit
to sanrise/kineto
that referenced
this pull request
Feb 12, 2026
Summary: Previously, kineto registered a permanent CUPTI callback on CUDA context creation to initialize the profiler. This blocked external tools like wprof from subscribing to CUPTI since only one subscriber is allowed. This change replaces the CUPTI callback mechanism with a delayed initialization approach using a condition_variable-based timer. The profiler now initializes 1 second after libkineto_init, freeing CUPTI for on-demand profiling tools. The new DelayedInitializer class supports immediate cancellation on shutdown, avoiding the blocking behavior of std::future destructors. Differential Revision: D92570679
sanrise
force-pushed
the
export-D92570679
branch
from
February 12, 2026 00:38
c5d7067 to
3a2d638
Compare
meta-codesync
Bot
changed the title
sanrise
force-pushed
the
export-D92570679
branch
from
July 30, 2026 20:46
3a2d638 to
ce808d6
Compare
meta-codesync
Bot
changed the title
sanrise
added a commit
to sanrise/kineto
that referenced
this pull request
Aug 3, 2026
Summary: **Problem** Kineto reserves CUPTI's one callback subscriber at process startup, blocking tools such as wprof even when Kineto is idle. **Why** The `RESOURCE_CONTEXT_CREATED` callback only delays Kineto initialization. Regular PyTorch profiling and trace-time CUPTI activity setup do not depend on it. **Fix** - **Internal initialization:** Register `DynoConfigLoader`, then initialize Kineto and start config polling from a late `RegisterInitFunc`. - **OSS behavior:** Register `DaemonConfigLoader` only when `KINETO_USE_DAEMON` is set. - **Loader precedence:** Keep an existing platform loader instead of replacing it with the OSS IPC loader. - **CUPTI ownership:** Remove the startup `RESOURCE_CONTEXT_CREATED` subscription while preserving regular profiling and trace-time activity setup. Reviewed By: scotts Differential Revision: D92570679
sanrise
force-pushed
the
export-D92570679
branch
from
August 3, 2026 19:23
ce808d6 to
95beaaf
Compare
Summary: **Problem** Kineto reserves CUPTI's one callback subscriber at process startup, blocking tools such as wprof even when Kineto is idle. **Why** The `RESOURCE_CONTEXT_CREATED` callback only delays Kineto initialization. Regular PyTorch profiling and trace-time CUPTI activity setup do not depend on it. **Fix** - **Internal initialization:** Register `DynoConfigLoader`, then initialize Kineto and start config polling from a late `RegisterInitFunc`. - **OSS behavior:** Register `DaemonConfigLoader` only when `KINETO_USE_DAEMON` is set. - **Loader precedence:** Keep an existing platform loader instead of replacing it with the OSS IPC loader. - **CUPTI ownership:** Remove the startup `RESOURCE_CONTEXT_CREATED` subscription while preserving regular profiling and trace-time activity setup. Reviewed By: scotts Differential Revision: D92570679
sanrise
force-pushed
the
export-D92570679
branch
from
August 4, 2026 21:12
95beaaf to
f759b25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Problem
Kineto reserves CUPTI's one callback subscriber at process startup, blocking tools such as wprof even when Kineto is idle.
Why
The
RESOURCE_CONTEXT_CREATEDcallback only delays Kineto initialization. Regular PyTorch profiling and trace-time CUPTI activity setup do not depend on it.Fix
DynoConfigLoader, then initialize Kineto and start config polling from a lateRegisterInitFunc.DaemonConfigLoaderonly whenKINETO_USE_DAEMONis set.RESOURCE_CONTEXT_CREATEDsubscription while preserving regular profiling and trace-time activity setup.Reviewed By: scotts
Differential Revision: D92570679