[slimtensor] Add non-owning storage mode for wrapping external memory #16772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add non-owning constructor to MaybeOwningStorage that allows wrapping external memory without taking ownership. This is needed for from_blob() which creates tensors from user-provided data pointers. Changes: - Add MaybeOwningStorage(device, data, nbytes) non-owning constructor - Add is_owning() method to query ownership mode - Non-owning storage uses no-op deleter so external memory is not freed Differential Revision: [D91202898](https://our.internmc.facebook.com/intern/diff/D91202898/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16772
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 70605bf with merge base 3cd3b92 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This was referenced Jan 22, 2026
This PR needs a
|
larryliu0820
approved these changes
Jan 22, 2026
…rnal memory" Add non-owning constructor to MaybeOwningStorage that allows wrapping external memory without taking ownership. This is needed for from_blob() which creates tensors from user-provided data pointers. Changes: - Add MaybeOwningStorage(device, data, nbytes) non-owning constructor - Add is_owning() method to query ownership mode - Non-owning storage uses no-op deleter so external memory is not freed Differential Revision: [D91202898](https://our.internmc.facebook.com/intern/diff/D91202898/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Jan 22, 2026
Pull Request resolved: #16772 Add non-owning constructor to MaybeOwningStorage that allows wrapping external memory without taking ownership. This is needed for from_blob() which creates tensors from user-provided data pointers. Changes: - Add MaybeOwningStorage(device, data, nbytes) non-owning constructor - Add is_owning() method to query ownership mode - Non-owning storage uses no-op deleter so external memory is not freed ghstack-source-id: 335102163 @exported-using-ghexport Differential Revision: [D91202898](https://our.internmc.facebook.com/intern/diff/D91202898/)
meta-codesync
bot
merged commit 1886bdc
into
gh/gasoonjia/112/base
183 of 192 checks passed
Gasoonjia
added a commit
that referenced
this pull request
Jan 22, 2026
…#16801) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #16772 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/112/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/112/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/111/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/112/orig Differential Revision: [D91202898](https://our.internmc.facebook.com/intern/diff/D91202898/) @diff-train-skip-merge --------- Co-authored-by: gasoonjia <gasoonjia@icloud.com> Co-authored-by: Gasoonjia <gasoonjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add non-owning constructor to MaybeOwningStorage that allows wrapping
external memory without taking ownership. This is needed for from_blob()
which creates tensors from user-provided data pointers.
Changes:
Differential Revision: D91202898