-
Notifications
You must be signed in to change notification settings - Fork 795
NXP backend: Added conversion and quantization of aten.unsqueeze #16467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXP backend: Added conversion and quantization of aten.unsqueeze #16467
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16467
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 81be94a with merge base e847384 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "module: nxp" |
|
@pytorchbot label "release notes: nxp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for conversion and quantization of aten.unsqueeze operations in the NXP backend. The implementation converts aten.unsqueeze operations to aten.view operations, which are already supported by the NXP backend.
Key Changes:
- Implemented a new pass
ConvertUnsqueezeToViewPassthat replacesaten.unsqueeze.defaultwithaten.view.defaultoperations - Integrated the new pass into the
NeutronAtenPassManagerpipeline - Added comprehensive test coverage for the conversion with various input shapes and dimension parameters
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
backends/nxp/aten_passes/convert_unsqueeze_to_view.py |
New file implementing the pass to convert unsqueeze operations to view operations |
backends/nxp/aten_passes/neutron_aten_pass_manager.py |
Added import and integration of ConvertUnsqueezeToViewPass into the pass manager |
backends/nxp/tests/models.py |
Added UnsqueezeAddModel test model for testing unsqueeze operations |
backends/nxp/tests/test_convert_unsqueeze_to_view_copy.py |
New test file with comprehensive tests for the unsqueeze-to-view conversion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Fixed issues previously mentioned in this PR: #16466
Additionally renamed the |
9b3848d to
81be94a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
adds conversion and quantization of aten.unsqueeze
Test plan
tests can be manually run using
pytest -c /dev/null backends/nxp/tests/cc @robert-kalmar @JakeStevens @digantdesai @MartinPavella