-
Notifications
You must be signed in to change notification settings - Fork 794
[slimtensor] Add CUDA DeviceType and extend Device class #16437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/gasoonjia/79/base
Are you sure you want to change the base?
Conversation
This diff adds CUDA device type support to SlimTensor's device infrastructure, preparing for CUDA tensor support in subsequent diffs. **Key changes:** 1. **`c10/core/DeviceType.h`** - Extended DeviceType enum: - Added `DeviceType::CUDA = 1` (matching PyTorch's enum value) - Added `kCUDA` constant for convenience - Updated `DeviceTypeName()` to support CUDA - Updated `isValidDeviceType()` to recognize CUDA - Updated `COMPILE_TIME_MAX_DEVICE_TYPES` to 2 2. **`c10/core/Device.h`** - Extended Device class: - Added `is_cuda()` method - Extended string constructor to parse "cuda", "CUDA", "cuda:N" formats - Updated `str()` to output CUDA device strings correctly Differential Revision: [D89825595](https://our.internmc.facebook.com/intern/diff/D89825595/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16437
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit 3bdd8a8 with merge base fd6fa87 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Stack from ghstack (oldest at bottom):
This diff adds CUDA device type support to SlimTensor's device infrastructure, preparing for CUDA tensor support in subsequent diffs.
Key changes:
c10/core/DeviceType.h- Extended DeviceType enum:DeviceType::CUDA = 1(matching PyTorch's enum value)kCUDAconstant for convenienceDeviceTypeName()to support CUDAisValidDeviceType()to recognize CUDACOMPILE_TIME_MAX_DEVICE_TYPESto 2c10/core/Device.h- Extended Device class:is_cuda()methodstr()to output CUDA device strings correctlyDifferential Revision: D89825595