Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jan 5, 2026

Stack from ghstack (oldest at bottom):

This diff adds CUDA device type support to SlimTensor's device infrastructure, preparing for CUDA tensor support in subsequent diffs.

Key changes:

  1. c10/core/DeviceType.h - Extended DeviceType enum:

    • Added DeviceType::CUDA = 1 (matching PyTorch's enum value)
    • Added kCUDA constant for convenience
    • Updated DeviceTypeName() to support CUDA
    • Updated isValidDeviceType() to recognize CUDA
    • Updated COMPILE_TIME_MAX_DEVICE_TYPES to 2
  2. c10/core/Device.h - Extended Device class:

    • Added is_cuda() method
    • Extended string constructor to parse "cuda", "CUDA", "cuda:N" formats
    • Updated str() to output CUDA device strings correctly

Differential Revision: D89825595

This diff adds CUDA device type support to SlimTensor's device infrastructure, preparing for CUDA tensor support in subsequent diffs.

**Key changes:**

1. **`c10/core/DeviceType.h`** - Extended DeviceType enum:
   - Added `DeviceType::CUDA = 1` (matching PyTorch's enum value)
   - Added `kCUDA` constant for convenience
   - Updated `DeviceTypeName()` to support CUDA
   - Updated `isValidDeviceType()` to recognize CUDA
   - Updated `COMPILE_TIME_MAX_DEVICE_TYPES` to 2

2. **`c10/core/Device.h`** - Extended Device class:
   - Added `is_cuda()` method
   - Extended string constructor to parse "cuda", "CUDA", "cuda:N" formats
   - Updated `str()` to output CUDA device strings correctly

Differential Revision: [D89825595](https://our.internmc.facebook.com/intern/diff/D89825595/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16437

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit 3bdd8a8 with merge base fd6fa87 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants