-
Notifications
You must be signed in to change notification settings - Fork 782
Better python resolution #16389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Better python resolution #16389
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16389
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ea06f7a with merge base 0dfda64 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @TareHimself! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thanks! This change makes sense and should make it more robust. Can you update to resolve the one lingering lint issue? I'm happy to merge it once the mandatory lint job is green. |
|
How do I resolve the lint issue ? not sure how to run the linter locally |
|
Also, does the CI succeeding mean it works with conda? I expect it to, just want to make sure |
|
@TareHimself Sure. For the local lintrunner, here's the setup and run commands: https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#lintrunner. Regarding conda, we do use conda for most of the CI jobs, so if CI is passing, it should be good. |
Summary
used find_package to resolve python