Skip to content

Conversation

@TareHimself
Copy link

Summary

used find_package to resolve python

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16389

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ea06f7a with merge base 0dfda64 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Dec 24, 2025

Hi @TareHimself!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 24, 2025
@GregoryComer
Copy link
Member

Thanks! This change makes sense and should make it more robust. Can you update to resolve the one lingering lint issue? I'm happy to merge it once the mandatory lint job is green.

@TareHimself
Copy link
Author

How do I resolve the lint issue ? not sure how to run the linter locally

@TareHimself
Copy link
Author

Also, does the CI succeeding mean it works with conda? I expect it to, just want to make sure

@GregoryComer
Copy link
Member

@TareHimself Sure. For the local lintrunner, here's the setup and run commands: https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#lintrunner. Regarding conda, we do use conda for most of the CI jobs, so if CI is passing, it should be good.

@GregoryComer GregoryComer added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants