add custom loss, optim, metrics for model_sweep#587
Open
Atharva9621 wants to merge 5 commits intopytorch-tabular:mainfrom
Open
add custom loss, optim, metrics for model_sweep#587Atharva9621 wants to merge 5 commits intopytorch-tabular:mainfrom
Atharva9621 wants to merge 5 commits intopytorch-tabular:mainfrom
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom loss functions, metrics, and optimizers to the model_sweep function, making it consistent with the TabularModel.fit() API.
Key Changes
- Added
custom_fit_paramsparameter tomodel_sweepfunction that accepts custom loss, metrics, and optimizer specifications - Updated validation logic to ensure rank_metric is "loss" when custom metrics are provided
- Enhanced test coverage with a new test case (
test_model_compare_custom) demonstrating custom fit parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/pytorch_tabular/tabular_model_sweep.py |
Added custom_fit_params parameter to model_sweep and _validate_args, with validation logic and documentation; unpacks params when calling prepare_model |
tests/test_common.py |
Updated _run_model_compare to accept and forward custom_fit_params; added new test case with custom loss, metrics, and optimizer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix test assertion Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix test assertion Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for custom loss and metrics in
model_sweepFixes #544
model_sweepin the same way astabular_model.fit()throughcustom_fit_params.custom_fit_paramsexpects a dictionary specifying the custom loss, metrics, or optimizer.Example usage
📚 Documentation preview 📚: https://pytorch-tabular--587.org.readthedocs.build/en/587/