Repository navigation
fix(csp): allow HTTPS images in report-only img-src - #3154
Merged
Merged
Conversation
/downloads/ and release pages load media from the S3 endpoint (s3.dualstack.us-east-2.amazonaws.com), devguide.python.org and images embedded in release notes (hugovk.dev, GitHub). None matched img-src, so every page view sent several violation reports; ~5M reports between Sep 30 and Oct 3 exhausted the PSF Sentry quota. Refs #3041
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSP allowed imgs pile up, each view of
downloadsis 7-8 images == 7-8 CSP reports and a lot of people visit/downloads