fix: Add direct MP4 source handling for 1Anime embeds - #1949
Closed
veloxiromus wants to merge 3 commits into
Closed
veloxiromus wants to merge 3 commits into
veloxiromus wants to merge 3 commits into
Conversation
U-L-M-S
reviewed
Sep 30, 2026
U-L-M-S
left a comment
Contributor
There was a problem hiding this comment.
Tried it on Sparks of Tomorrow ep 2, plays fine now. Two things I ran into while testing, the first one is the suggestion below.
-d without yt-dlp writes nothing for these episodes. ffmpeg quits with Option extension_picky not found, that option only exists for playlists. This in download() fixed it for me:
# extension_picky only exists for playlists, ffmpeg refuses to open a plain mp4 with it
case "$1" in
*.m3u8*) _picky="-extension_picky 0" ;;
*) _picky="" ;;
esac
ffmpeg $_picky -referer "$refr" -readrate 10 -loglevel error -stats -i "$1" -c copy "$download_dir/$_name.mp4" $3Small thing: the title needs a fix: prefix, otherwise the title check fails.
Co-authored-by: U-L-M-S <96896184+U-L-M-S@users.noreply.github.com>
Author
|
@U-L-M-S doing angels work on this project ngl |
Collaborator
|
no. bad code and superflous comments |
Author
|
im never doing a pr again |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Type of change
Description
Fixes #1942
Changed the 1Anime extractor to get the direct video source from the embed instead of using the old player ID method.
Tested with Sparks of Tomorrow, 1Anime playback works again and other servers still work.
Sorry about the old #1945, i didnt understand the head branch setup and opened it from my "next" branch.
Checklist