Skip to content

fix: Add direct MP4 source handling for 1Anime embeds - #1949

Closed
veloxiromus wants to merge 3 commits into
pystardust:nextfrom
veloxiromus:fix-1anime-src
Closed

veloxiromus wants to merge 3 commits into
pystardust:nextfrom
veloxiromus:fix-1anime-src

Conversation

@veloxiromus

@veloxiromus veloxiromus commented Sep 30, 2026 •

Copy link
Copy Markdown

Type of change

  • Bug fix

Description

Fixes #1942

Changed the 1Anime extractor to get the direct video source from the embed instead of using the old player ID method.

Tested with Sparks of Tomorrow, 1Anime playback works again and other servers still work.

Sorry about the old #1945, i didnt understand the head branch setup and opened it from my "next" branch.

Checklist

  • any anime playing
  • bumped version

  • next, prev, replay and select work
  • "-c" history and continue work
  • "-d" downloads work
  • "-e" (select episode) aka "-r" (range selection) works
  • "-S" select index works
  • "-q" quality works
  • "-s" syncplay works
  • "-v" vlc works
  • "--dub" and regular (sub) mode both work
  • "--nextep-countdown" countdown to next ep works

  • "-h" help info is up to date
  • Readme is up to date
  • Man page is up to date

@U-L-M-S U-L-M-S left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it on Sparks of Tomorrow ep 2, plays fine now. Two things I ran into while testing, the first one is the suggestion below.

-d without yt-dlp writes nothing for these episodes. ffmpeg quits with Option extension_picky not found, that option only exists for playlists. This in download() fixed it for me:

    # extension_picky only exists for playlists, ffmpeg refuses to open a plain mp4 with it
    case "$1" in
        *.m3u8*) _picky="-extension_picky 0" ;;
        *) _picky="" ;;
    esac
    ffmpeg $_picky -referer "$refr" -readrate 10 -loglevel error -stats -i "$1" -c copy "$download_dir/$_name.mp4" $3

Small thing: the title needs a fix: prefix, otherwise the title check fails.

Comment thread ani-cli Outdated
Co-authored-by: U-L-M-S <96896184+U-L-M-S@users.noreply.github.com>
@veloxiromus veloxiromus changed the title Add direct MP4 source handling for 1Anime embeds fix: Add direct MP4 source handling for 1Anime embeds Sep 30, 2026
@veloxiromus

veloxiromus commented Sep 30, 2026 •

Copy link
Copy Markdown
Author

@U-L-M-S doing angels work on this project ngl

@port19x

port19x commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

no. bad code and superflous comments

@port19x port19x closed this Sep 30, 2026
@veloxiromus

Copy link
Copy Markdown
Author

im never doing a pr again

@justchokingaround

Copy link
Copy Markdown
Collaborator

Screenshot_20261001-132213.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants