fix: No sources for sub! - #1946
Closed
Simon-J-Hloska wants to merge 3 commits into
Closed
Simon-J-Hloska wants to merge 3 commits into
Simon-J-Hloska wants to merge 3 commits into
Conversation
Simon-J-Hloska
requested review from
Derisis13,
justchokingaround and
port19x
as code owners
September 29, 2026 20:24
port19x
requested changes
Sep 30, 2026
port19x
left a comment
Collaborator
There was a problem hiding this comment.
Seems to be fixed rn, but feel free to keep open for a couple more days in case the issues return
Collaborator
|
closing in favor of #1941 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Small follow-up update:
MegaPlay was returning subtitle tracks correctly in the
tracksarray, but my initial parser was too strict about the JSON formatting and could leavesub_linkempty.I updated the extraction logic to parse individual caption track objects more robustly and now prefer:
Subtitles are now being picked up correctly alongside the MegaPlay HLS source.
Re-ran
shfmt,shellcheck, and the local playback tests after the change.Checklist
-chistory and continue work-ddownloads work-e(select episode) aka-r(range selection) works-Sselect index works-qquality works-ssyncplay works-vvlc works--duband regular (sub) mode both work--nextep-countdowncountdown to next ep works-hhelp info is up to dateAdditional Testcases
(these don't block a merge)
--skipani-skip works--no-detachno detach works--exit-after-playauto exit after playing worksCopy Pasta