Skip to content

fix: No sources for sub! - #1946

Closed
Simon-J-Hloska wants to merge 3 commits into
pystardust:masterfrom
Simon-J-Hloska:master
Closed

Simon-J-Hloska wants to merge 3 commits into
pystardust:masterfrom
Simon-J-Hloska:master

Conversation

@Simon-J-Hloska

Copy link
Copy Markdown

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

Small follow-up update:

MegaPlay was returning subtitle tracks correctly in the tracks array, but my initial parser was too strict about the JSON formatting and could leave sub_link empty.

I updated the extraction logic to parse individual caption track objects more robustly and now prefer:

  1. English subtitles
  2. the provider's default caption track
  3. the first available caption track

Subtitles are now being picked up correctly alongside the MegaPlay HLS source.

Re-ran shfmt, shellcheck, and the local playback tests after the change.

Checklist

  • any anime playing
  • [ x] bumped version

  • [ x] next, prev, replay and select work
  • [ x] -c history and continue work
  • [ x] -d downloads work
  • [ x] -e (select episode) aka -r (range selection) works
  • [ x] -S select index works
  • [ x] -q quality works
  • [ x] -s syncplay works
  • [ x] -v vlc works
  • [ x] --dub and regular (sub) mode both work
  • [ x] --nextep-countdown countdown to next ep works

  • [ x] -h help info is up to date
  • [ x] Readme is up to date
  • [ x] Man page is up to date

Additional Testcases

(these don't block a merge)

  • --skip ani-skip works
  • --no-detach no detach works
  • --exit-after-play auto exit after playing works

Copy Pasta

./ani-cli -V
./ani-cli -S 1 -e 1 -d flcl
./ani-cli -S 1 -e 1 -q worst -v flcl
./ani-cli -c -s --dub

@port19x port19x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fixed rn, but feel free to keep open for a couple more days in case the issues return

@port19x

port19x commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

closing in favor of #1941

@port19x port19x closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants