Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 55 additions & 4 deletions numpyro/distributions/truncated.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from jax import Array, lax
import jax.numpy as jnp
import jax.random as random
from jax.scipy.special import gammainc, gammaincc, logsumexp
from jax.scipy.special import gammainc, gammaincc, log_ndtr, logsumexp
from jax.typing import ArrayLike

from numpyro._typing import NumLike
Expand Down Expand Up @@ -145,6 +145,54 @@ def icdf(self, q: ArrayLike) -> Array:
)
return jnp.where(jnp.less(q, 0), jnp.nan, ppf)

@staticmethod
@jax.jit
def _truncated_normal_icdf(
q: ArrayLike,
prob: Array,
quantile: Array,
low: ArrayLike,
high: ArrayLike,
loc: ArrayLike,
scale: ArrayLike,
sign: Array,
) -> Array:
use_log_tail = (
(prob < jnp.finfo(prob.dtype).tiny) & jnp.greater(q, 0) & jnp.less(q, 1)
)

def log_tail_quantile():
def log_tail_at(bound):
return _at_bound(
lambda x: log_ndtr(sign * (x - loc) / scale),
bound,
jnp.asarray(loc),
jnp.where(sign * bound < 0, -jnp.inf, 0.0),
)

safe_q = jnp.where(use_log_tail, q, 0.5)
log_prob = jnp.logaddexp(
jnp.log1p(-safe_q) + log_tail_at(low),
jnp.log(safe_q) + log_tail_at(high),
)
log_prob = jnp.where(use_log_tail, log_prob, -100.0)

# Invert the standard normal log CDF in the far tail by Newton's
# method, starting from the leading term log Phi(x) ≈ -x²/2.
def step(_, x):
log_cdf = log_ndtr(x)
log_pdf = -0.5 * (x**2 + math.log(2 * math.pi))
return x - (log_cdf - log_prob) * jnp.exp(log_cdf - log_pdf)

z = lax.fori_loop(0, 3, step, -jnp.sqrt(-2 * log_prob))
tail_quantile = jnp.clip(loc + sign * scale * z, low, high)
return jnp.where(use_log_tail, tail_quantile, quantile)

quantile = lax.cond(jnp.any(use_log_tail), log_tail_quantile, lambda: quantile)
return jnp.where(
jnp.equal(q, 0), low, jnp.where(jnp.equal(q, 1), high, quantile)
)

def cdf(self, value: ArrayLike) -> Array:
# For left truncated distribution: CDF(x) = (F(x) - F(low)) / (1 - F(low))
# where F is the base distribution CDF.
Expand Down Expand Up @@ -471,9 +519,12 @@ def icdf(self, q: ArrayLike) -> Array:
# A = 2 * loc - icdf[(1 - q) * cdf(2*loc-low)) + q * cdf(2*loc - high)]
loc = self.base_dist.loc
sign = jnp.where(loc >= self.low, 1.0, -1.0)
ppf = (1 - sign) * loc + sign * self.base_dist.icdf(
clamp_probs((1 - q) * self._tail_prob_at_low + q * self._tail_prob_at_high)
)
prob = (1 - q) * self._tail_prob_at_low + q * self._tail_prob_at_high
ppf = (1 - sign) * loc + sign * self.base_dist.icdf(clamp_probs(prob))
if isinstance(self.base_dist, Normal):
ppf = LeftTruncatedDistribution._truncated_normal_icdf(
q, prob, ppf, self.low, self.high, loc, self.base_dist.scale, sign
)
return jnp.where(
jnp.logical_or(jnp.less(q, 0), jnp.greater(q, 1)), jnp.nan, ppf
)
Expand Down
20 changes: 14 additions & 6 deletions test/test_distributions.py
Original file line number Diff line number Diff line change
Expand Up @@ -4877,12 +4877,20 @@ def test_truncated_normal_log_prob_in_tail(value):
assert_allclose(numpyro_log_prob, jax_log_prob, rtol=1e-06)


def test_sample_truncated_normal_in_tail():
# test, if samples from distributions truncated in
# tail of distribution returns any inf's
tail_dist = dist.TruncatedNormal(loc=0, scale=1, low=-16, high=-15)
samples = tail_dist.sample(random.key(0), sample_shape=(10_000,))
assert ~jnp.isinf(samples).any()
@pytest.mark.parametrize("low,high", [(-16, -15), (15, 16)])
def test_sample_truncated_normal_in_tail(low, high):
tail_dist = dist.TruncatedNormal(
loc=jnp.float32(0),
scale=jnp.float32(1),
low=jnp.float32(low),
high=jnp.float32(high),
)
q = np.array([0.1, 0.5, 0.9], dtype=np.float32)
assert_allclose(
tail_dist.icdf(q), osp.truncnorm.ppf(q, low, high), rtol=0, atol=2e-5
)
samples = tail_dist.sample(random.key(0), sample_shape=(256,))
assert tail_dist.support(samples).all()


@jax.enable_custom_prng()
Expand Down
Loading