Directly convert IndependentDistribution to base distribution - #443
Merged
Conversation
34 tasks
fritzo
approved these changes
Jan 26, 2021
fritzo
left a comment
fritzo
left a comment
Member
There was a problem hiding this comment.
LGTM once tests pass.
In the longer term will we deprecate Independent in favor of Lambda?
Member
Author
I'm not sure, I guess it depends on how much it ends up being used in places that are closer to user code. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #386. Should unblock #427.
This PR modifies
to_funsorconversion ofIndependentDistributions to directly modify parameter inputs and outputs viafunsor.Lambdarather than representing them withfunsor.terms.Independent, which was breaking some pattern matching in #427.Tested:
test_distribution_generic.pythat useIndependent, and more directly in Add factory for dynamic TransformOp #427