Misc improvements #112
Merged
Misc improvements #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of using -O2 by default we now use -O3 for all Cython compilations. This can provide better performance with gcc. - Always use cdivision=True for Cython code which leads to large improvements for Cython code performance. - Add a `COMPYLE_DEBUG` env var option which makes it easier to debug.
nauaneed
reviewed
Apr 3, 2025
| self.blocks = [] | ||
| self.mod = None | ||
| self._use_double = get_config().use_double | ||
| if os.environ.get('COMPYLE_DEBUG') is not None: |
Contributor
There was a problem hiding this comment.
I think, this will evaluate to True even if COMPYLE_DEBUG=0 or COMPYLE_DEBUG=False.
Contributor
There was a problem hiding this comment.
Maybe os.environ.get("COMPYLE_DEBUG", 'False').lower() in ['true', '1']
Contributor
There was a problem hiding this comment.
Could also use pydantic or attrs, I guess, but adds a dependency.
Contributor
Author
There was a problem hiding this comment.
That is intentional, at this point if the variable exists and is set it will treat it, if someone doesn't want it, they can unset the variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPYLE_DEBUGenv var option which makes it easier to debug.