Skip to content

Add output_columns to conditional_join - #1753

Open
samukweku wants to merge 9 commits into
devfrom
issue-1751-output-columns
Open

samukweku wants to merge 9 commits into
devfrom
issue-1751-output-columns

Conversation

@samukweku

Copy link
Copy Markdown
Collaborator

Summary

  • add side-aware output_columns projection to conditional_join
  • materialize only selected columns while preserving predicate inputs
  • deprecate df_columns and right_columns with compatibility retained
  • document the API, examples, release version, and planned 0.33.0 removal

Validation

  • pixi run pytest tests/functions/test_conditional_join.py -q
  • pixi run pytest --doctest-modules janitor/functions/conditional_join.py -q
  • commit hooks passed

Closes #1751

@samukweku samukweku self-assigned this Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://pyjanitor-devs.github.io/pyjanitor/pr-preview/pr-1753/

Built to branch gh-pages at 2026-10-14 04:13 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@samukweku
samukweku requested a review from ericmjl October 5, 2026 04:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconsider deprecation of conditional_join df_columns and right_columns

1 participant