Add preferred features for preconfigure_default_device#817
Merged
Conversation
Vipitis
reviewed
Jun 24, 2026
Vipitis
reviewed
Jun 24, 2026
Co-authored-by: Jan <Vipitis@users.noreply.github.com>
Vipitis
previously approved these changes
Jun 24, 2026
almarklein
commented
Jun 24, 2026
Vipitis
previously approved these changes
Jun 24, 2026
Closed
Member
Author
|
sry, I took some more time to clean it up just a bit more. |
Vipitis
approved these changes
Jun 25, 2026
Vipitis
left a comment
Vipitis
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, I like the utility. I got a private branch with some ideas regarding #789 that could be added to it in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves two problems:
These can be though of as being the same; when running in the browser, the native features are not available.
Very practically, this will allow PyGfx to enable filtered uint16 textures, see pygfx/pygfx#1305