Merged
Conversation
433a987 to
62728cc
Compare
62728cc to
380e701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
UpscaleModelLoaderexport/runtime path for current ComfyUI builds and updates the docs to reflect the current install and export flow.What changed
COMFYUI_PATHand keep the resolved ComfyUI path at the front ofsys.pathNODE_CLASS_MAPPINGSuntil needed so exporter tests can inject fake mappings without importing the full ComfyUI runtimeCOMFYUI_PATHat runtimeNODE_CLASS_MAPPINGS[...]for node classes that exist in the runtime but are not importable from a normal dotted module pathRegression coverage
UpscaleModelLoaderintests/test_upscale_model_loader_export.pyDocumentation updates
File -> Save As Scriptcustom_nodesCOMFYUI_PATHmore clearly for CLI/exported-script usageSave As Scriptprompt()limitationsVerification
uv run python -m unittest tests.test_upscale_model_loader_export -vScope
This PR intentionally includes the README/docs refresh already present on the branch along with the
#143fix. It does not include the separate runtime harness / E2E validation work or agent/spec scaffolding.