Probabilistic versions of FSS and spatial contingency metrics#523
Open
DANIELV95 wants to merge 7 commits intopySTEPS:masterfrom
Open
Probabilistic versions of FSS and spatial contingency metrics#523DANIELV95 wants to merge 7 commits intopySTEPS:masterfrom
DANIELV95 wants to merge 7 commits intopySTEPS:masterfrom
Conversation
- Added lines to print averaged gamma and phi values - Corrected for inputs longer than required (vil.shape[0] > ar_order + 2)
…r multiple window sizes, thresholds, timesteps and members
…, required for det_cat_fct_spatial, and changed pred to fct
Member
|
hi @DANIELV95 many thanks for this nice contribution! before diving into the details, I see that this PR includes changes to the anvil module that do not seem to be related to verification methods. Was this intended? |
Author
|
Hello @dnerini, no, sorry for that, it shouldn't be in this PR but it was a small change to print the coefficients and I forgot to remove it, should I change that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added probabilistic versions of FSS (pfss, avfss and agfss) and spatial contingency scores (POD,FAR, ETS, ...) to be able to compute scores for ensemble forecasts for multiple window sizes, thresholds, and timesteps.
FSS versions reference:
Necker, T., Wolfgruber, L., Kugler, L., Weissmann, M., Dorninger, M. & Serafin, S. (2024) The fractions skill score for ensemble forecast verification. Quarterly Journal of the Royal Meteorological Society, 150(764), 4457–4477. Available from: https://doi.org/10.1002/qj.4824