Conversation
|
@all-contributors please add @zenon18 for docs, review |
|
I've put up a pull request to add @zenon18! 🎉 |
InessaPawson
left a comment
InessaPawson
left a comment
There was a problem hiding this comment.
Thanks so much for taking this on, @zenon18! Splitting the Editor Guide makes it easier to navigate and also makes the overall review process easier to understand.
Could you please rebase this PR? The branch predates the publication fast-track documentation changes on main, so several of the newly split pages currently reintroduce the outdated policy.
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* Remove merge conflict markers Leftover merge conflict markers from gen AI update * Remove duplicate novel method warning * Fix numbering in package scope for novel methods * Fix dead links in quote from Adam Sparks
* ci: update docs workflow to Python 3.11 * Apply suggestion from @lwasser * Pin actions --------- Co-authored-by: Leah Wasser <leah@pyopensci.org>
…yOpenSci#395) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
…ture (pyOpenSci#391) Co-authored-by: Leah Wasser <leah@pyopensci.org>
|
@InessaPawson I believe I correctly rebased and fixed your suggestions. Let me know if I missed anything. I'm having trouble trying to fix the merge conflict that it has with the no longer existing how-to/editors-guide.md. Open to suggestions on that. |
6bf8d23 to
984469d
Compare
Co-authored-by: Inessa Pawson <inessapawson@gmail.com>
Co-authored-by: Inessa Pawson <inessapawson@gmail.com>
Co-authored-by: Inessa Pawson <inessapawson@gmail.com>
InessaPawson
left a comment
InessaPawson
left a comment
There was a problem hiding this comment.
@zenon18 GitHub's web conflict editor doesn't handle rename/edit conflicts well. Fortunately, git was tracking the rename correctly. I was able to resolve the conflict locally.
Let’s address just one more issue, and the PR will be ready to merge:
how-to/editors-guide.html has been a stable public URL for a long time, and it's linked from open review issues, our onboarding doc, and likely a few Slack posts. This PR updates the one in-repo reference, but external links will start throwing 404 after deploy since we don't currently have a redirect mechanism in conf.py. Please add sphinx-reredirects so the old URL forwards to its successor. I suggest review-process.html as the target since most existing links point at the review workflow.
We are very close. Thank you for your patience through the rebase!
|
@shaunagm While reviewing this PR, I noticed several variations of the private Slack channel name for the Editorial Team are used throughout the repo. Could you confirm which one is correct? I’m not in the channel, so I’ll need your help here. |
5 participants
closes #337 The editor's guide is now a section with its details broken up among multiple pages.
Editor Guide->Position Description&Review ProcessPosition Description(everything upto checklist + closing notes on editorial process)Review Process(rest of the Editor Guide)Review ProcessFinding ReviewersOnboarding ReviewersFinding & Onboarding Editorsmoved under Editor Guide sectionFinding & Onboarding Reviewers->Finding Reviewers&Onboarding ReviewersFinding Reviewers(everything upto Peer Mentorship)Onboarding Reviewers(Peer Mentorship)