Skip to content

Handle aoi>90 correctly in spectrum.spectrl2#1349

Merged
kandersolar merged 3 commits into
pvlib:masterfrom
kandersolar:spectrl2_aoi_fix
Dec 8, 2021
Merged

Handle aoi>90 correctly in spectrum.spectrl2#1349
kandersolar merged 3 commits into
pvlib:masterfrom
kandersolar:spectrl2_aoi_fix

Conversation

@kandersolar

Copy link
Copy Markdown
Member

Basically just copying over the two checks in haydavies.

@kandersolar kandersolar added the bug label Dec 4, 2021
@kandersolar kandersolar added this to the 0.9.1 milestone Dec 4, 2021

@wholmgren wholmgren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worthwhile to add a similar note to irradiance.haydavies? Something like "When supplying projection_ratio, consider constraining its values when zenith angle approaches 90 degrees. See code for details." Certainly not required here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spectrum.spectrl2 calculates negative irradiance for angle of incidence outside +/- 90°

3 participants