Handle aoi>90 correctly in spectrum.spectrl2#1349
Merged
Merged
Conversation
cwhanse
approved these changes
Dec 6, 2021
wholmgren
approved these changes
Dec 8, 2021
wholmgren
left a comment
Member
There was a problem hiding this comment.
Is it worthwhile to add a similar note to irradiance.haydavies? Something like "When supplying projection_ratio, consider constraining its values when zenith angle approaches 90 degrees. See code for details." Certainly not required here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spectrum.spectrl2calculates negative irradiance for angle of incidence outside +/- 90° #1348Updates entries todocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Basically just copying over the two checks in
haydavies.