Repository navigation
fix: load CLI package.json via static require - #1923
Merged
chrisvxd merged 1 commit intoNov 19, 2026
Merged
Conversation
chrisvxd
approved these changes
Nov 19, 2026
chrisvxd
deleted the
xavie/puck-626-monitor-failing-on-nodejs-potential-path
branch
November 19, 2026 11:45
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PUCK-626.
Oneleet flagged
require(pkgPath)inpackages/core/bin/cli.mjsas a potential path traversal becauserequirereceived a variable. It was a false positive, sincepkgPathcomes fromrequire.resolveon a fixed package name. This PR passes the literal"@puckeditor/cli/package.json"torequireinstead, so the next scan should clear the finding.Runtime behaviour doesn't change:
requireandrequire.resolvelook up the same file.pkgPathstays because the script uses it to find the CLI's directory.Testing
node packages/core/bin/cli.mjs --helpprints the CLI help and exits 0node packages/core/bin/cli.mjs --versionmatches the installed@puckeditor/cliversion🤖 Generated with Claude Code