Skip to content

chore(deps): upgrade react-native-nitro-modules to 0.37.2 - #410

Open
coreyphillips wants to merge 1 commit into
mainfrom
chore/upgrade-nitro-modules-0.37.2
Open

coreyphillips wants to merge 1 commit into
mainfrom
chore/upgrade-nitro-modules-0.37.2

Conversation

@coreyphillips

Copy link
Copy Markdown
Collaborator

Summary

Changes

  • package.json: react-native-nitro-modules 0.37.1 to 0.37.2.
  • yarn.lock: 0.37.2 now depends on nitro-core 0.37.2, which is added. react-native-mmkv (the only Nitro based dependency) stays at 4.3.2, which is the latest release.
  • ios/Podfile.lock: only the NitroModules version and checksum change. No other pods change.
  • patches/react-native-nitro-modules+0.37.1.patch: removed.

Upstream release notes: https://github.com/margelo/nitro/releases/tag/v0.37.2. Besides the crash fix, 0.37.2 is mostly CI, benchmark, and nitrogen fixes, plus a package restructure (ios/ became apple/, and shared code moved into nitro-core).

Testing

iOS, Release build for the simulator with Xcode 27.2 (27B52):

  • Fresh install launches to the Terms screen on iOS 17.4, 18.5, 26.2, and 27.2.
  • Compared every libc++ and libc++abi symbol the app binary imports against the iOS 17.4 runtime exports: none missing, so the 0.37.2 fix covers what the patch covered.
  • Upgrade over an existing install: installed the CI build from fix(ios): patch nitro so Xcode 27 builds launch on iOS below 18 #409 (Nitro 0.37.1 with the patch), launched it so it wrote its MMKV store, then installed this build over it without uninstalling. The app launched, the MMKV store and its persist:root entry were intact, and there were no MMKV or Nitro errors in the logs. This only covers first launch state, since the check did not go through onboarding.

Android, ./gradlew :app:assembleRelease -PreactNativeArchitectures=arm64-v8a -PPUBKYRING_DEBUG_SIGNING=true on JDK 17:

  • Build succeeds. On an Android 17 arm64 emulator the app launches to the Terms screen, libNitroModules.so and libNitroMmkv.so load, and logcat shows no crashes.

JS checks:

  • yarn typecheck passes.
  • yarn lint: 0 errors, 2 warnings (no JS changes in this PR).
  • yarn test: 47 suites, 468 tests pass.

Not tested: a physical device, and full flows beyond the first screen. The iOS and Android Maestro flows in CI cover the full flows.

Note on Podfile.lock

Running pod install with the system Ruby 2.6 rewrites every spec checksum, because its JSON library formats empty arrays differently from the newer Ruby used to create the committed lockfile. To keep the diff to the actual change, the lockfile here keeps the committed checksums and updates only the NitroModules entry. Its checksum was computed from the installed podspec JSON in the same format as the existing entries, which reproduces the committed checksums for the unchanged pods (for example NitroMmkv). CI runs a fresh pod install against this lockfile, so a green iOS build there confirms it resolves correctly.

0.37.2 includes the upstream fix for the Xcode 27 launch crash on iOS below 18
(margelo/nitro#1652, fixed by margelo/nitro#1824), so the temporary
patch-package patch added in #409 is no longer needed and is removed.

0.37.2 now depends on nitro-core 0.37.2, which yarn adds to the lockfile.
In Podfile.lock only the NitroModules version and checksum change.

@pwltr pwltr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed e882a2f.

The published 0.37.2 package builds its exceptions with throw and std::current_exception() instead of std::make_exception_ptr in both places the removed patch changed (RuntimeError.hpp and Promise.hpp), so dropping the patch keeps the Xcode 27 launch fix for iOS below 18. The yarn.lock hashes match the published tarballs, nothing in the app references the package's old ios/ path, and CI's pod install and both end-to-end runs pass on the updated lockfile. No findings.

Review details

General review
Model: Claude Opus 5.5
Reasoning effort: high

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants