Repository navigation
chore(deps): upgrade react-native-nitro-modules to 0.37.2 - #410
Open
coreyphillips wants to merge 1 commit into
Open
coreyphillips wants to merge 1 commit into
coreyphillips wants to merge 1 commit into
Conversation
0.37.2 includes the upstream fix for the Xcode 27 launch crash on iOS below 18 (margelo/nitro#1652, fixed by margelo/nitro#1824), so the temporary patch-package patch added in #409 is no longer needed and is removed. 0.37.2 now depends on nitro-core 0.37.2, which yarn adds to the lockfile. In Podfile.lock only the NitroModules version and checksum change.
pwltr
approved these changes
Nov 19, 2026
pwltr
left a comment
Contributor
There was a problem hiding this comment.
Reviewed e882a2f.
The published 0.37.2 package builds its exceptions with throw and std::current_exception() instead of std::make_exception_ptr in both places the removed patch changed (RuntimeError.hpp and Promise.hpp), so dropping the patch keeps the Xcode 27 launch fix for iOS below 18. The yarn.lock hashes match the published tarballs, nothing in the app references the package's old ios/ path, and CI's pod install and both end-to-end runs pass on the updated lockfile. No findings.
Review details
General review
Model: Claude Opus 5.5
Reasoning effort: high
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-native-nitro-modulesfrom 0.37.1 to 0.37.2, the current stable release.Changes
package.json:react-native-nitro-modules0.37.1 to 0.37.2.yarn.lock: 0.37.2 now depends onnitro-core0.37.2, which is added.react-native-mmkv(the only Nitro based dependency) stays at 4.3.2, which is the latest release.ios/Podfile.lock: only theNitroModulesversion and checksum change. No other pods change.patches/react-native-nitro-modules+0.37.1.patch: removed.Upstream release notes: https://github.com/margelo/nitro/releases/tag/v0.37.2. Besides the crash fix, 0.37.2 is mostly CI, benchmark, and nitrogen fixes, plus a package restructure (
ios/becameapple/, and shared code moved intonitro-core).Testing
iOS, Release build for the simulator with Xcode 27.2 (27B52):
persist:rootentry were intact, and there were no MMKV or Nitro errors in the logs. This only covers first launch state, since the check did not go through onboarding.Android,
./gradlew :app:assembleRelease -PreactNativeArchitectures=arm64-v8a -PPUBKYRING_DEBUG_SIGNING=trueon JDK 17:libNitroModules.soandlibNitroMmkv.soload, and logcat shows no crashes.JS checks:
yarn typecheckpasses.yarn lint: 0 errors, 2 warnings (no JS changes in this PR).yarn test: 47 suites, 468 tests pass.Not tested: a physical device, and full flows beyond the first screen. The iOS and Android Maestro flows in CI cover the full flows.
Note on Podfile.lock
Running
pod installwith the system Ruby 2.6 rewrites every spec checksum, because its JSON library formats empty arrays differently from the newer Ruby used to create the committed lockfile. To keep the diff to the actual change, the lockfile here keeps the committed checksums and updates only theNitroModulesentry. Its checksum was computed from the installed podspec JSON in the same format as the existing entries, which reproduces the committed checksums for the unchanged pods (for exampleNitroMmkv). CI runs a freshpod installagainst this lockfile, so a green iOS build there confirms it resolves correctly.