Repository navigation
fix: remove bottom bar from homeserver settings - #404
Merged
Merged
Conversation
pwltr
force-pushed
the
fix/homeservers-bottom-inset
branch
from
November 9, 2026 15:08
70ad22b to
35cd41f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homeservers settings wrapped its list in a black SafeAreaView, leaving a fixed bar below the scroll area. Use a plain View with SafeAreaInset inside the scroll content, matching About and Authorized App, so the background extends to the bottom while the last button keeps its safe-area spacing.
This is the local follow-up fix that was not included in #357.
The homeserver UI test harness now supplies safe-area insets for the real SafeAreaInset component.
Validation: all 469 tests across 47 suites, typecheck, targeted ESLint, Prettier, and diff checks pass. Fresh CI is pending on
35cd41f. Native visual verification has not been run for this follow-up.