Repository navigation
Fix: check datasets of providers without a @return type - #275
Merged
Merged
Conversation
A provider with only a native return type was reported as MixedReturnStatement and its datasets went unchecked. They are now checked against the type Psalm infers from the body of a provider declared in the test case or in a trait it uses. Other providers (parent or external class, yield from, non-iterable inferred type) keep the MixedReturnStatement, which now asks for a @return type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providers with only a native return type (
iterable,array,Generator) getMixedReturnStatement, and their datasets are not checked.Before
After
Datasets are checked against the type Psalm infers from the provider's body, one dataset at a time, for providers declared in the test class or in a trait it uses. Providers in a parent or external class, and providers using
yield from, keepMixedReturnStatement, which now ends with; add a @return type to NS\BaseTest::provide().Fixes #269